Skip to content

Label the unpinned MSVC arm64 CI leg 14.52 - #422

Merged
sgerbino merged 1 commit into
cppalliance:developfrom
sgerbino:pr/msvc-arm64-14.52
Nov 16, 2026
Merged

sgerbino merged 1 commit into
cppalliance:developfrom
sgerbino:pr/msvc-arm64-14.52

Conversation

@sgerbino

@sgerbino sgerbino commented Nov 16, 2026 •

Copy link
Copy Markdown
Collaborator

The MSVC 14.51: C++20 (arm64) job fails on every run at the Configure MSVC step:

Expected MSVC 14.51 for ARM64, got: Microsoft (R) C/C++ Optimizing Compiler Version 19.52.37029 for ARM64

The windows-11-vs2026-arm image (win11-vs2026-arm64/20261112.217) ships VS 18.12, whose default toolset is 14.52. Its only side-by-side MSVC toolset is 14.44, so the leg cannot be pinned back to 14.51. This leg has no msvc_toolset pin and builds with the image default. The step that checks the compiler against the matrix version caught the change as intended.

Changes

  • ci: label the unpinned MSVC arm64 leg 14.52. The entry in .github/compilers.json now says 14.52. The job is renamed to MSVC 14.52: C++20 (arm64). The B2 toolset stays msvc-14.5, and the pinned 14.44 arm64 leg is unchanged.

The x64 MSVC 14.51 legs on windows-2025-vs2026 are not pinned either. They will fail the same way when that image moves to 14.52.

Testing

  • generate-matrix.py produces the same MSVC jobs as before, apart from the new name.
  • No branch protection requires the old job name.
  • Only this PR's arm64 run can confirm the fix.

Summary by CodeRabbit

  • Updates
    • Updated the MSVC compiler version used for Windows 11 ARM builds.

The windows-11-vs2026-arm image now defaults to MSVC 14.52 and no
longer installs 14.51 side by side, so the leg cannot be pinned back.
The Configure MSVC step rejected the stale label on every run.
@coderabbitai

coderabbitai Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The MSVC Windows 11 ARM compiler entry in .github/compilers.json now specifies version 14.52 instead of 14.51.

Changes: Compiler configuration

Layer / File(s) Summary
Update MSVC ARM version
.github/compilers.json
The MSVC Windows 11 ARM compiler version changes from 14.51 to 14.52.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Bug fix

Suggested reviewers: mvandeberg

Merge Risk: Minimal · up to 8b909

This updates a CI matrix label so the unpinned MSVC arm64 job matches the toolset the runner image now ships. It does not affect production code. The only remaining check is the PR's own arm64 CI run.

Pre-merge checks: Passed 4

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title names the change: the unpinned MSVC arm64 CI leg's label moves from 14.51 to 14.52. The raw summary confirms the only edit is the version string in .github/compilers.json for the Windows 11 …
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title names the change: the unpinned MSVC arm64 CI leg's label moves from 14.51 to 14.52. The raw summary confirms the only edit is the version string in .github/compilers.json for the Windows 11 ARM MSVC entry, and the objectives describe the same label update and job rename. The title is specific and matches the main change, so it passes.

Finishing Touches

Generate unit tests (beta)

  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

A rabbit checks the version line,
“Fourteen point fifty-two looks fine!”
One small change now marks the page,
A newer compiler takes the stage.
I hop away, my work is done.

Recent review info

Run configuration

Commits

Reviewing files that changed from the base of the PR and between 68153e1 and 8b909ba.

Files selected for processing: 1

  • .github/compilers.json

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

@greptile-apps

greptile-apps Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 5/5

[Low impact] This PR appears safe to merge.

Summary

Updates the unpinned ARM64 job in .github/compilers.json from MSVC 14.51 to 14.52.

  • The ARM64 CI job now expects MSVC 14.52.

Reviews (1) · Last reviewed commit: "ci: label the unpinned MSVC arm64 leg 14..." · Reviewed by Greptile

@cppalliance-bot

Copy link
Copy Markdown

An automated preview of the documentation is available at https://422.corosio.prtest3.cppalliance.org/index.html

If more commits are pushed to the pull request, the docs will rebuild at the same URL.

2026-11-16 16:53:05 UTC

@cppalliance-bot

Copy link
Copy Markdown

GCOVR code coverage report https://422.corosio.prtest3.cppalliance.org/gcovr/index.html
LCOV code coverage report https://422.corosio.prtest3.cppalliance.org/genhtml/index.html
Coverage Diff Report https://422.corosio.prtest3.cppalliance.org/diff-report/index.html

Build time: 2026-11-16 17:12:51 UTC

@sgerbino
sgerbino merged commit 53ceec1 into cppalliance:develop Nov 16, 2026
44 checks passed
@github-project-automation github-project-automation Bot moved this from Backlog to Done in Beast2 Nov 16, 2026
@sgerbino
sgerbino deleted the pr/msvc-arm64-14.52 branch November 16, 2026 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants