Repository navigation
fix: wrap piped if conditions in parentheses - #527
Closed
shenxianpeng wants to merge 1 commit into
Closed
shenxianpeng wants to merge 1 commit into
shenxianpeng wants to merge 1 commit into
Conversation
nushell reads `if $env.X | is-not-empty {` as `if $env.X` piped into
another command, so the script fails to parse with "missing then_block"
before cpp-linter starts. This broke every run of the action on this
branch, whatever the inputs were.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not needed: d34259f, pushed to
v3.0.0-rc0a minute before this pull request was opened, already makes the same two-line change. Closing.Problem
Every run of the action at b30de81 fails in the "Run cpp-linter" step before cpp-linter starts:
nushell reads
if $env.X | is-not-empty {asif $env.Xpiped into another command, so theifhas no block. It is a parse error, so it does not depend on the inputs.Fix
Wrap the two conditions added in b30de81 in parentheses, like every other
ifinaction.yml: