Repository navigation
Conversation
…CMake comment safety.launch.py's use_sim_time description said the relay and its timeouts run on the boot clock either way; under use_sim_time they run on the sim's /clock (robot_clock.hpp, the README's Robot time), and only the heartbeat and the exit stay on the steady and boot clocks. CMakeLists.txt said twice that zlib is only for the npz writer's crc32; one comment now says it. No behaviour change. The package was audited for dead code and holds none. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015EG7p8sgY1ZVi6unbbLp4J
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A dead-code audit of
golem_safetyfound no dead code: every function, class, constant, config key, file, tool, script, fixture and dependency has a live user. The package was already cleaned in the 2026-11-09 audit (docs/superpowers/specs/2026-11-09-repo-cleanup-leftovers.md). This PR has only two comment fixes, and it changes no behaviour.Changed
launch/safety.launch.py: theuse_sim_timeargument's description was stale. It said "the relay and its timeouts run on the boot clock either way". Underuse_sim_timethey actually run on the sim's/clock(robot_clock.hpp, the README's Robot time section, CLAUDE.md §8). Only the heartbeat and the exit stay on the steady and boot clocks. The new description says this and notes that the node refusestruewithoutsim:=true.CMakeLists.txt: the comment "zlib is only for the npz writer's crc32" appeared twice. It is now one comment.Evidence that nothing is dead
include/andsrc/acrosssrc,includeandtest. Every function, method andk*constant has a non-test caller. EverySafetyConfigfield is read outsideconfig.cpp, bysafety_core,safety_nodeordump_config.config.cppparses match the keys inconfig/example.yaml, one for one.pyflakesreports no unused imports or names intools/,scripts/ortest/. Every module-level constant and function is referenced.relay_latency_probe.py: the README andtest_relay_latency_probe.py.generate_robot_data.pyand{h12,g1}_joint_limits.py: the README and therobots/*.yamlheaders.combine_chunks.py: the README,docs/g1/safety.mdandtest_chunk_files.py.golem_safety_dump_config: the README anddocs/g1/first-session.md.lowcmd_crc.jsonand*_joint_limits.jsonis read bytest_lowcmd.cpportest_robot_data.py.package.xmldependencies: each one has an importer or user.rosgraph_msgsandament_index_pythonare used byconftest.py, andros2launchbytest_node_ros.py.used to,previously,no longer,legacy,TODO,today, ...) found none.Kept because removing them is an owner decision or a behaviour change
Each of these is already listed in the 2026-11-09 leftovers doc:
config/h12/*_safety_full.yamlandconfig/g1/full.yaml: no bringup starts them, but they are tested, listed in the README, and the pairing check refuses them on purpose.estop_response.mode: dampand the G1 configs'kd: no config selectsdamp, but it is a documented estop option, tested bytest_lowcmd,test_configandtest_node_ros. Removing it would also touch PR golem_safety: copy mode_machine from /lowstate; write nothing before the robot's first /lowstate #18's files.motor_slotsin the robot profiles: removing it is a schema change.test/fixtures/*_joint_limits.json: the independent check of the generated profiles.robot_clock.hpp,dump_config_main.cppand some tests. I left them alone: this is include-what-you-use churn, not dead code.I edited none of PR #18's files and none of PR #19's.
Tests
Inside
golem_ros, on a private copy of the workspace (domain 121;test_node_rosuses 91):🤖 Generated with Claude Code
https://claude.ai/code/session_015EG7p8sgY1ZVi6unbbLp4J