Repository navigation
Conversation
install_robocasa_patches guarded every RoboCasa entry point it patches (env_utils itself, set_robot_base, set_robot_to_position, _ROBOT_POS_OFFSETS) with a fallback and a warning for a RoboCasa that lacks it. The robocasa image's pinned RoboCasa has all of them, and make_kitchen_env imports robocasa right after the patch anyway, so the fallbacks never run: patch both functions unconditionally. make_kitchen_env's **kwargs pass-through (all three definitions) has no caller that passes anything through it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015EG7p8sgY1ZVi6unbbLp4J
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dead-code sweep of
golem_robocasa/(third_party excluded). The package was already clean, so this is small. Default behaviour is unchanged: same topics, DDS, knobs, defaults, spawn and sensors. The surface goldens are untouched.Removed
robosuite_common.install_robocasa_patchesfallbacks: thetry/exceptaroundfrom robocasa.utils import env_utils(and its warning), thegetattr(EU, ..., None)guards onset_robot_base,set_robot_to_positionand_ROBOT_POS_OFFSETS, theis not Nonebranches, and the "no RoboCasa placement entry point found" warning. Evidence: ingolem_sim_robocasa:latest,env_utilshas both functions ((env, anchor_pos, anchor_ori, rot_dev, pos_dev_x, pos_dev_y)and(env, global_pos)) and_ROBOT_POS_OFFSETSis adict. Also,make_kitchen_envimportsrobocasaon the line after the patch, so a missing RoboCasa already failed there. Both functions are now patched unconditionally, with the same wrappers.**kwargsonmake_kitchen_env(inrobosuite_common,h1_2_robosuiteandg1/g1_robosuite): a repo-wide grep finds no caller that passes extra keyword arguments.Net: 3 files, +37 / -58.
Checked and kept
format_action,_important_geoms,dof,default_*,_eef_name,arm_type,top_offset, ...): robosuite calls them, not this repo.unitree_common.LowStateWriter.bytes_forandmid360.LidarFrame.rays: only tests read them, but they are howtest_lowstate_writer.py(numpy wire bytes vs the SDK serializer and CRC) and the lidar frame tests check production behaviour. Kept, unsure.GOLEM_*knob the package reads is documented in CLAUDE.md or docs, or passed by compose or test scripts. Everyrealsense_profile.yamlkey is read, and every one is in the example. Every module is imported. Every definition has a docstring. There is no commented-out code, and I found no comment that breaks the repo's comment rules.Tests (worktree, before / after)
tests/robocasa/run_in_container.sh(ROS_DOMAIN_ID=129): 195 OK (1 skip) / 195 OK (1 skip)tests/robocasa/g1/run_in_container.sh: 7 files, 59 tests OK / samepytest -q tests/docker: 115 passed aftertests/simandtests/g1.🤖 Generated with Claude Code
https://claude.ai/code/session_015EG7p8sgY1ZVi6unbbLp4J