Repository navigation
Conversation
Dex3Hand took cmd_topic and state_topic to replace rt/dex3/<side>/cmd and state; no caller or test passes them, so the driver always used the defaults. The parameters are gone and the topics are fixed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015EG7p8sgY1ZVi6unbbLp4J
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dead-code sweep of
core_ws/src/dex_3. No behaviour change.Removed
Dex3Hand(..., cmd_topic=None, state_topic=None, ...)index_3/driver.py: nothing in the repo passes these two parameters.hand_node.pypasses only kp, kd, rate_hz, max_speed and clock, and the tests pass only rate_hz, clock and bad settings, all by keyword. The driver therefore always usedrt/dex3/<side>/cmdandrt/dex3/<side>/state, which are now fixed in the code.Checked and kept (all used)
dex3.py: every constant and function is used by the driver, the node or the launch file.hand_node.py: every parameter is read, andSimTimeis used underuse_sim_time.launch/hands.launch.py: named in CLAUDE.md §4 and the README as the way to run the hands alone.package.xmldeps (rclpy,sensor_msgs,std_msgs,std_srvs,custom_ros_messages,launch,launch_ros): all imported.Kept, unsure
Tests
colcon test --packages-select dex_3ingolem_ros: 48 tests, 0 failures, the same before and after.🤖 Generated with Claude Code
https://claude.ai/code/session_015EG7p8sgY1ZVi6unbbLp4J