Skip to content

golem_bringup: remove dead code - #22

Open
maxconwa wants to merge 1 commit into
mainfrom
cleanup/golem_bringup
Open

maxconwa wants to merge 1 commit into
mainfrom
cleanup/golem_bringup

Conversation

@maxconwa

Copy link
Copy Markdown
Contributor

Dead-code sweep of core_ws/src/golem_bringup. The package was already lean: every launch file, launch argument, Python helper, script and exec_depend has a user. This PR fixes only two stale or garbled docstring lines. No behaviour change.

Removed / fixed

  • launch/h12/h12_sim.launch.py usage line: dropped [use_nav:=false]. The file declares no use_nav argument because navigation always starts (CLAUDE.md §6). The line now names [use_skills:=false], which the file does declare.
  • launch/h12/lmg_sim.launch.py docstring: the usage block ran into the description with a stray leading space. A blank line now separates them.

Checked and kept (all used)

  • All 18 launch files: each is named by CLAUDE.md §6, a test, docker_stack.sh/tests, or included by another launch file.
  • golem_bringup/{include,h12_legs,sim_estop}.py: imported by the launch files.
  • scripts/slider_debugger.py: a manual tool. docker/RosDockerfile installs Tk for it. It is the only user of the custom_ros_messages, magpie_msgs and python3-scipy exec_depends, so those stay too.
  • common_cmds.md: linked from docs/RUNNING.md. I spot-checked the constants and parameters it names in golem_skills and golem_lowerbody_rl, and they all exist.
  • Every other exec_depend (tf2_ros, cl_realsense, model_server, livox_ros_driver2, estop, magpie_control, lmg_deploy, dex_3, ...) is used by a launch file.
  • setup.py's files() filter that skips dangling --symlink-install links.

Kept, unsure

  • h12_sim/lmg_sim pass urdf_file to h12_state at its default value. This is redundant, but removing it would let an undeclared urdf_file:= on the command line take effect, because Humble includes are not scoped. Left as is.

g1_* launch files untouched (PR #18).

Tests

colcon test --packages-select golem_bringup in golem_ros (with golem_slam's source beside it, which test_real_lidar_config.py reads): 84 tests, 0 failures, 1 skipped, the same before and after. pytest tests/docker on the host: 112 passed. 3 errors come from test_isaac_domain.py, which needs the CL_isaaclab_sim submodule; that submodule is not checked out in this worktree, so the errors are unrelated to this change.

🤖 Generated with Claude Code

https://claude.ai/code/session_015EG7p8sgY1ZVi6unbbLp4J

h12_sim.launch.py's usage named use_nav:=false, an argument it does not
declare (navigation always starts); it now names use_skills:=false. The
usage block of lmg_sim.launch.py ran into its description with a stray
leading space; a blank line separates them.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015EG7p8sgY1ZVi6unbbLp4J
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant