Repository navigation
Conversation
h12_sim.launch.py's usage named use_nav:=false, an argument it does not declare (navigation always starts); it now names use_skills:=false. The usage block of lmg_sim.launch.py ran into its description with a stray leading space; a blank line separates them. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015EG7p8sgY1ZVi6unbbLp4J
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dead-code sweep of
core_ws/src/golem_bringup. The package was already lean: every launch file, launch argument, Python helper, script andexec_dependhas a user. This PR fixes only two stale or garbled docstring lines. No behaviour change.Removed / fixed
launch/h12/h12_sim.launch.pyusage line: dropped[use_nav:=false]. The file declares nouse_navargument because navigation always starts (CLAUDE.md §6). The line now names[use_skills:=false], which the file does declare.launch/h12/lmg_sim.launch.pydocstring: the usage block ran into the description with a stray leading space. A blank line now separates them.Checked and kept (all used)
docker_stack.sh/tests, or included by another launch file.golem_bringup/{include,h12_legs,sim_estop}.py: imported by the launch files.scripts/slider_debugger.py: a manual tool.docker/RosDockerfileinstalls Tk for it. It is the only user of thecustom_ros_messages,magpie_msgsandpython3-scipyexec_depends, so those stay too.common_cmds.md: linked fromdocs/RUNNING.md. I spot-checked the constants and parameters it names ingolem_skillsandgolem_lowerbody_rl, and they all exist.exec_depend(tf2_ros,cl_realsense,model_server,livox_ros_driver2,estop,magpie_control,lmg_deploy,dex_3, ...) is used by a launch file.setup.py'sfiles()filter that skips dangling--symlink-installlinks.Kept, unsure
h12_sim/lmg_simpassurdf_filetoh12_stateat its default value. This is redundant, but removing it would let an undeclaredurdf_file:=on the command line take effect, because Humble includes are not scoped. Left as is.g1_*launch files untouched (PR #18).Tests
colcon test --packages-select golem_bringupingolem_ros(withgolem_slam's source beside it, whichtest_real_lidar_config.pyreads): 84 tests, 0 failures, 1 skipped, the same before and after.pytest tests/dockeron the host: 112 passed. 3 errors come fromtest_isaac_domain.py, which needs theCL_isaaclab_simsubmodule; that submodule is not checked out in this worktree, so the errors are unrelated to this change.🤖 Generated with Claude Code
https://claude.ai/code/session_015EG7p8sgY1ZVi6unbbLp4J