Repository navigation
Conversation
The lmg launches take no policy argument, and the real-robot and safety notes narrated history; the code had no dead definitions, imports or keys. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015EG7p8sgY1ZVi6unbbLp4J
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I searched
lmg_deployfor dead code and found almost none. The package was already cleaned on 2026-11-09. The only change is to the README, where three spots were stale. No code, config or behaviour changes.Removed (README only)
policy, ... arguments" under Real robot:lmg_sim.launch.pyandlmg_real.launch.pydeclare nopolicyargument (policies/README.md: "there is nopolicy:=").Checked and found used (kept)
lmg_deploy/*.pyis used by the node or controller, not only by tests (grep of each name). Every test helper is used.lmg_deploy/andtest/reports nothing.exec_dependis imported. Every key in the deploy config and inexport.yamlis read;imu.offsetandsourceare written by the external exporter.config/policy_template.yamlandtest/data/explicit500.yamlare read by tests and named in the README.Kept, unsure
test/sim_drive.py: a manual sim drive helper that no test or script runs; the README names it. Its arm-goal phase is refused by the shipped policy (arm_goals: false).control_hzparameter: it duplicatescontrol_dt. Removing it would change the node's interface, anddocs/superpowers/specs/2026-11-09-repo-cleanup-leftovers.mdalready lists it.LivoxAttitudebuffer_s/still_*,ArmKinematicspelvis_frame): these are interface, not dead code.bags/: kept as instructed.Not in scope, worth noting
package.xmldoes not listsensor_msgs, although the node importssensor_msgs.msg.Imu.setup.pyandpackage.xmlis stillTODO: License declaration.Tests
colcon test --packages-select lmg_deployingolem_ros(domain 126,H12_URDFset):🤖 Generated with Claude Code
https://claude.ai/code/session_015EG7p8sgY1ZVi6unbbLp4J