Repository navigation
Conversation
k-g-k
requested review from
Mephistic,
alexjball,
kiminkim724,
mertbagt,
mvictor55,
nesanders,
sashamaryl and
timblais
as code owners
November 20, 2026 19:56
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follows #2378, which carried #2369's work into dev. Improvements to sidebar behavior and collapsible groups.
Sidebar scroll
The sidebar had its own scroll inside the page (a known issue in #2369). When the list was taller than the space under the navbar, the sidebar and the page competed for the same scroll: scrolling over the sidebar moved the list instead of the page. Two scrolls in the same place will always compete, so the fix removes the sidebar's own scroll and ties it to the page scroll.
max-heightandoverflow-y: auto. Keptposition: stickyunder the navbar.useTwoWaySticky(ConferenceRail.tsx), which switches the edge the sidebar rests on when the scroll changes direction. It updates at most once per frame, on scroll, resize, and changes to the sidebar's height (aResizeObserver, for collapsible groups opening and closing), and sets the sidebar's position directly on the element while the browser does the scrolling.Sidebar groups
The sidebar was getting busy, so I moved Not Covered conferences into their own sidebar group, building upon the collapsible group for closed conferences that is hidden in the UI. In order to add this functionality cleanly, I created a component (
SidebarGroups) that builds each group from a small set of categories, so every group, including the hidden closed conferences, is set up the same way.Collapsible group (Not Covered) behavior:
How the component is set up:
SidebarGroups.tsx.ConferenceRail.tsxkeeps the sidebar's frame and scroll.categories.ts, each built from a conference's existingstatus,coveredandreportBillId. No backend or data changes.rule)bills)SIDEBAR_GROUPShas three fields:data(its category),display("inline"for the main list,"grouped"for a collapsible group) andshown(on or off). A group's heading is its category's name (category.*inconferences.json).closedConferencesflag (on since Flipping conference committee flags on production #2380) still loads them across the rest of the site, including their own pages and bill and hearing pages.Other User-Facing Changes
No User Impact
isSittingrather than manually hiding the closed conferences.Checklist
firestore.indexes.json(No new queries.)Screenshots
To follow.
Known issues
None.
Extra Deploy Steps
Frontend only.
Steps to test/reproduce