Repository navigation
fix: account for GPU time-slicing replicas in GPU health check - #30
Merged
Merged
Conversation
With GPU time-slicing, nvidia.com/gpu.count reports physical GPUs while allocatable nvidia.com/gpu is physical GPUs x nvidia.com/gpu.replicas, so healthy time-sliced nodes were reported as GPUCountMismatch. Compute the expected count as gpu.count x gpu.replicas, treating a missing or invalid replicas label as 1. Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
jokestax
approved these changes
Nov 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GPUCountMismatchnvidia.com/gpu.count × nvidia.com/gpu.replicasnvidia.com/gpu.replicaslabel as1, so the behaviour for non-shared GPU nodes is unchangedHasGPUis unchanged and still decides GPU nodes fromnvidia.com/gpu.countonlyProblem
With GPU time-slicing,
nvidia.com/gpu.countreports the number of physical GPUs, while allocatablenvidia.com/gpuisphysical GPUs × nvidia.com/gpu.replicas(NVIDIA GPU Operator docs).The checker expected
1but saw4, so healthy time-sliced nodes failed the GPU check and became reboot targets after the 10-minute threshold.