Skip to content

Bump gRPC to 1.85.1 (CVE-2025-55163) - #223

Merged
stsingh merged 3 commits into
mainfrom
sahej/cve-grpc
Nov 17, 2026
Merged

stsingh merged 3 commits into
mainfrom
sahej/cve-grpc

Conversation

@stsingh

@stsingh stsingh commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Why. CVE-2025-55163 (Netty "MadeYouReset" HTTP/2 DoS) affects the Netty bundled in grpc-netty-shaded 1.64.0. It's fixed in 1.75.0 and later.

Fix.

  • Raise grpcVersion to 1.85.1.
  • Guava 33.4+ (via gRPC) no longer brings in checker-qual, so declare it directly. chalk-java uses its @Nullable.
  • Relocate org.jspecify, which Guava now pulls in, in the shaded jar.
  • The checked-in 1.64 stubs are unchanged and still compile.

Verified. On JDK 17:

  • All io.grpc:* dependencies resolve to 1.85.1, and an OSV scan no longer reports the CVE.
  • Compile and shadowJar pass. Everything left unrelocated in the shaded jar was already in the main-based jar (android/annotation, .proto resources and zstd natives). The only additions are two .proto dirs.
  • 140 of 144 tests pass. The other 4 need staging credentials, which CI provides.

Rollout. Merge #222 first. It declares protobuf-java 3.25.9, which matches what gRPC 1.85.1 needs. Otherwise Maven users of the unshaded jar would resolve the 3.25.1 this branch still declares.

Related: FDE-86. Jackson/protobuf are in #222.

🤖 Generated with Claude Code

gRPC 1.85 pulls Guava 33.x, which no longer brings checker-qual
transitively; declare it directly since chalk-java uses its @nullable
annotations. Relocate org.jspecify (new via Guava) in the shaded jar.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
stsingh and others added 2 commits November 17, 2026 22:20
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@stsingh
stsingh marked this pull request as ready for review November 17, 2026 22:31
@stsingh
stsingh merged commit 88495d1 into main Nov 17, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants