Repository navigation
Bump gRPC to 1.85.1 (CVE-2025-55163) - #223
Merged
Merged
Conversation
gRPC 1.85 pulls Guava 33.x, which no longer brings checker-qual transitively; declare it directly since chalk-java uses its @nullable annotations. Relocate org.jspecify (new via Guava) in the shaded jar. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
stsingh
marked this pull request as ready for review
November 17, 2026 22:31
TBuckholz5
approved these changes
Nov 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why. CVE-2025-55163 (Netty "MadeYouReset" HTTP/2 DoS) affects the Netty bundled in
grpc-netty-shaded1.64.0. It's fixed in 1.75.0 and later.Fix.
grpcVersionto 1.85.1.checker-qual, so declare it directly. chalk-java uses its@Nullable.org.jspecify, which Guava now pulls in, in the shaded jar.Verified. On JDK 17:
io.grpc:*dependencies resolve to 1.85.1, and an OSV scan no longer reports the CVE.shadowJarpass. Everything left unrelocated in the shaded jar was already in the main-based jar (android/annotation,.protoresources and zstd natives). The only additions are two.protodirs.Rollout. Merge #222 first. It declares protobuf-java 3.25.9, which matches what gRPC 1.85.1 needs. Otherwise Maven users of the unshaded jar would resolve the 3.25.1 this branch still declares.
Related: FDE-86. Jackson/protobuf are in #222.
🤖 Generated with Claude Code