Skip to content

ci: shard the control-plane Website e2e and move guard suites out of CI scope - #1650

Open
blove wants to merge 1 commit into
mainfrom
blove/ci-shard-control-plane
Open

blove wants to merge 1 commit into
mainfrom
blove/ci-shard-control-plane

Conversation

@blove

@blove blove commented Nov 18, 2026

Copy link
Copy Markdown
Contributor

What changes

1. Website — e2e (control-plane) runs as three shards. It is the longest job on a small PR (15.0 to 16.7 min). Each shard builds and starts the same runtimes; only the test list is divided (--shard=n/3). playwright --list locally: 371 tests unsharded, 124 + 124 + 123 across the shards.

2. The guard suites move from CI scope to a new CI guards job. Every scoped job waits for CI scope, and about 50 s of it was guard tests (Test CI scope classifier, the Debug static preflight, Validate CI workflow guards). CI scope now does scope detection only.

What stays the same

  • CI — required needs CI guards and fails unless it succeeds, on PRs and merge-queue candidates.
  • Deploy → Vercel, Canonical demo → Vercel and AG-UI demo → Vercel need CI guards; the two always() deploys check its result explicitly.
  • No test, suite or guard is removed.

Behaviour change to be aware of

A guard failure used to stop every other job from starting. Now the other jobs run and the gate fails at the end. Coverage is the same; a run with a broken guard spends more runner time before failing.

Cost

Two more runners per run that selects Website e2e, and roughly 17 more execution minutes, because each shard repeats about 8.5 min of setup (install, Chromium, builds, server startup).

Expected effect, to be measured on this PR's run

  • Longest control-plane job: about 10.5 to 11 min, down from 15.0 to 16.7. Tests are only about 6.5 min of the job, so sharding cannot go much lower without cutting the fixed setup.
  • CI scope: about 50 s shorter.

Verification

  • node --test scripts/ci-workflow.spec.mjs: 202 pass, including new contracts for the guards job, the gate, the deploys and the shard divisor.
  • npx nx test scripts: pass.
  • ag-ui-a2ui-configuration, ag-ui-client-tools-preparation, cockpit-matrix, toolchain-policy specs: pass.
  • scripts/ci-scope.spec.mjs stalls on this macOS machine partway through (325 passed, none failed before the stall); the one test edited here passes on its own. The full list runs in this PR's CI guards job.
  • actionlint: no new findings.

🤖 Generated with Claude Code

…CI scope

Split the control-plane Website suite across three runners. Each shard
builds and starts the same runtimes; only the test list is divided.

Move the always-run guard suites from the CI scope job into a new CI guards
job. Every scoped job waits for CI scope, so it now carries only scope
detection. CI — required and all production deploys require CI guards.
@blove
blove enabled auto-merge November 18, 2026 02:34

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant