Repository navigation
Conversation
…defined
Angular gives every registry entry a default readiness fallback:
defineAngularRegistry pairs each component with DefaultFallbackComponent,
and render-element mounts that fallback while any resolved prop is
undefined (or a schema fails), latching once the real component mounts,
per element and per repeat row. A2UI catalogs get the same treatment, so
components that arrive before updateDataModel shimmer instead of
rendering empty labels.
React only gated explicit { kind: 'readiness' } entries, so plain
components and the whole a2uiBasicCatalog() mounted at once with
undefined props.
RenderSpec now applies Angular's rule by default: a registered component
waits behind RenderPendingFallback (GenerativeUiSkeleton markup) while
any resolved prop is undefined, then mounts and stays mounted for that
element. A readiness entry keeps its own predicate and shows the tree's
placeholder when it has no fallback, as Angular does with
fallback ?? DefaultFallbackComponent. The unknown-type `fallback` is not
gated. `pendingFallback` customizes the placeholder; `null` restores the
previous immediate mounting. A per-entry opt-out is a readiness entry
whose isReady always returns true.
A2UI: the basic catalog's inputs (TextField, CheckBox, ChoicePicker,
DateTimeInput, Slider) wait on every prop except their own `value`, so an
unseeded field the person fills in is not stuck on the placeholder, which
Angular's literal rule would do. A2uiSurface and A2uiMessageSurfaces take
`pendingFallback`; with null the surface uses an ungated catalog. Chat's
generativeUi options forward `pendingFallback` too.
A ready-on-first-render readiness gate now starts admitted, so the real
view renders once instead of twice. Element lifecycle events are
unchanged: an element reports `mounted` once when its placeholder first
renders, as Angular reports it from ngOnInit.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
blove
enabled auto-merge
November 18, 2026 02:01
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Angular gives every registry entry a default readiness fallback.
defineAngularRegistrypairs each component withDefaultFallbackComponent.render-element.component.ts(notReady,mountClass, and the per-indexrepeatMountedReallatch) mounts that fallback while any resolved prop isundefinedor an optional schema fails, then latches once the real component mounts.internals/element-readiness.tschecks every resolved prop, not just bound ones; in practice only unresolved expressions produceundefined. A2UI catalogs get the same behavior throughtoRenderRegistry, so components that arrive beforeupdateDataModelshimmer.React only gated explicit
{ kind: 'readiness' }entries. Plain components and all ofa2uiBasicCatalog()mounted at once with undefined props, so labels and fields rendered empty.What changed:
RenderSpecdefault (Angular parity): a registered component now waits behind the newRenderPendingFallbackwhile any resolved prop isundefined. The placeholder uses theGenerativeUiSkeletonmarkup and classes. Once ready, the component mounts and stays mounted for that element. Each repeat row latches on its own. The unknown-typefallbackis not gated. React registry entries cannot carry a schema, so only the undefined check applies.isReady. An entry with nofallbacknow shows the tree placeholder, matching Angular'sentry.fallback ?? DefaultFallbackComponent.pendingFallbackprop onRenderSpecreplaces the placeholder.pendingFallback={null}restores the old immediate mounting. To opt out a single entry, register it as a readiness entry withisReady: () => true.A2uiSurface,A2uiMessageSurfacesand the chatgenerativeUioptions forwardpendingFallback.value. This deliberately differs from Angular. Angular's literal rule leaves an input bound to an unseeded path on the fallback forever, so the person can never type into it. Existing React specs type into unseeded fields. WithpendingFallback={null},A2uiSurfaceuses an ungated catalog.a2ui/styles.cssstyles the placeholder with A2UI tokens.mountedonce, when the placeholder first renders. Angular reports it the same way, fromngOnInitbefore readiness. DevTools marks reportfallbackand thenmountedthrough the existing gate.Existing specs that relied on immediate mounting with undefined props now opt out with
pendingFallback={null}or assert the placeholder. This covers the readiness direct-view specs, seeded-state, computed unknown function, the A2UI DateTimeInput bound max, and the cockpit dashboard "Waiting" specs.Verification
NX_DAEMON=false npx nx run-many -t test lint -p react: 102 files, 1539 tests pass. Lint has 0 errors; the existing warnings are unchanged.npx nx run react:type-tests: passes.node --test scripts/react-parity/verify-packages.spec.mjs: 103 pass, 0 fail.node scripts/react-parity/inventory.mjs --check --drift warn: valid. The only output is the informational baseline-drift notice.npx vitest runin apps/website: the docs content rules pass. Three files fail in this worktree only, for environmental reasons:posthog-nodedoes not resolve through the symlinked node_modules, and API Extractor rejects a fixture outside the workspace.react-debug-preview.specpasses when rerun alone.RenderSpecor A2UI: the cockpit render, generative-ui, json-render and a2ui projects, and native-conversation-react. In the parallel run, three failed under machine load; each passes when rerun alone. Two cockpit dashboard specs were updated to expect the placeholder.fixture-testdependency asserts Node 22, and this machine runs Node 24. Run without that dependency, 7 tests pass and 1 fails because the backend never returns a response; the page is still waiting at "Waiting for the saved response…" and no surface rendered.🤖 Generated with Claude Code