Skip to content

feat: a request card offers only the allow its runtime applies (D-248) - #225

Queued
blove wants to merge 4 commits into
mainfrom
blove/approval-choices
Queued

blove wants to merge 4 commits into
mainfrom
blove/approval-choices

Conversation

@blove

@blove blove commented Nov 18, 2026

Copy link
Copy Markdown
Contributor

Hill climb defect 8 (R07.1, the one hard gate that failed): the request card offered "Allow for session" on every runtime, and the label was true only on Codex.

Runtime What the button did
Codex What it said: later matching prompts in the session are not asked.
Claude Code The same as "Allow once" (D-018 sent a plain allow).
B4 More than it said: B4 keeps an "always" itself, past the session.

What changed

  • allowScope on the request. Each adapter writes it into the payload it already builds: session on Codex's command and file-change approvals, always on a B4 prompt unless it said allowAlways: false, none on Claude Code. AllowScope in WorkspaceProtocol reads it.
  • The card. RequestChoices gives its buttons: "Allow once" and "Deny", plus "Allow for session" or "Always allow" only where the request has a scope. Both wider buttons still send allow_always; no wire or schema change.
  • Refused, not narrowed. SessionService refuses allow_always on a request with no scope before the adapter is called, so the CLI's --accept-session and a phone's relayed answer are held to what the card offers. The request stays pending. The adapters no longer narrow silently.
  • Several answers. A multiSelect question draws a toggle per option and answers with the ticked labels in the question's order.
  • CLI. The answer hint lists --accept-session only for a request with a scope.

Amends D-018 and D-021. Design: docs/superpowers/specs/2026-11-17-approval-choices-design.md (this is its step 1; step 2, a real session allow on Claude Code, waits on a live recording).

Verification

docs/verification/2026-11-17-a-request-offers-only-the-allow-its-runtime-applies.md.

  • Lint clean; 525 + 1525 tests passed before main was merged in, and the affected suites (143 tests) pass after.
  • aWiderAllowOnARequestThatOffersNoneIsRefused and RequestChoicesTests failed before their change. The adapter tests were written with their code and not seen failing; the record lists which.
  • One independent review: nothing critical or important. Two minors left and recorded (multi-select ticks keyed by label; --accept-session --decline together is now refused on a request with no scope).

Not verified

  • The card and the toggles on screen, on the Mac or the phone, and with VoiceOver.
  • Any live runtime. In particular, whether Codex takes acceptForSession on every command approval (network approvals may not), and B4 interrupts that are not permission prompts.
  • The two xcodebuild app builds.

Also here

docs/verification/2026-11-17-claude-code-task-tools-confirmed-live.md: D-247's two fixes confirmed in the installed Local build.

🤖 Generated with Claude Code

blove and others added 4 commits November 17, 2026 15:54
Adapters write allowScope into a request's payload: session on Codex's
approvals, always on a B4 prompt that allows it, none on Claude Code. An
adapter refuses a wider allow it cannot apply instead of narrowing it.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
…none

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
The card draws its buttons from the request's allowScope: Allow once and
Deny, with Allow for session (Codex) or Always allow (B4) only where the
runtime applies one. A multiSelect question takes several answers. The
CLI's answer hint lists --accept-session only where the request offers it.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
@blove
blove enabled auto-merge November 18, 2026 00:49
@blove
blove added this pull request to the merge queue Nov 18, 2026
Any commits made after this event will not be merged.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant