Repository navigation
Conversation
D-244 replaced the two layout shards with one job; the step was still "Every shard passed" and its variable SHARDS. Renamed to "The layout job passed" and LAYOUT, in the workflow and the two tests that read them. The required check's name is unchanged. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
D-244 replaced the two iOS layout shards with one job. The combining check's step was still called "Every shard passed" and read a variable named
SHARDS..github/workflows/ci.yml: the step is "The layout job passed" and the variable isLAYOUT. The shell is otherwise the same.Scripts/tests/test_ci_scope.pyfinds the step by its new name and passesLAYOUT;Scripts/tests/test_ios_layout_simulator.pyasserts the two shell lines with the new variable.The required check's name, "iOS navigation and banner regression tests", is unchanged. No decision record: nothing about what the check accepts changes.
Checked locally: 37 script tests,
actionlint.🤖 Generated with Claude Code