Skip to content

ci: the layout check's step is named for the one job it reads - #223

Open
blove wants to merge 1 commit into
mainfrom
blove/layout-check-step-name
Open

blove wants to merge 1 commit into
mainfrom
blove/layout-check-step-name

Conversation

@blove

@blove blove commented Nov 17, 2026

Copy link
Copy Markdown
Contributor

D-244 replaced the two iOS layout shards with one job. The combining check's step was still called "Every shard passed" and read a variable named SHARDS.

  • .github/workflows/ci.yml: the step is "The layout job passed" and the variable is LAYOUT. The shell is otherwise the same.
  • Scripts/tests/test_ci_scope.py finds the step by its new name and passes LAYOUT; Scripts/tests/test_ios_layout_simulator.py asserts the two shell lines with the new variable.

The required check's name, "iOS navigation and banner regression tests", is unchanged. No decision record: nothing about what the check accepts changes.

Checked locally: 37 script tests, actionlint.

🤖 Generated with Claude Code

D-244 replaced the two layout shards with one job; the step was still "Every shard passed" and its
variable SHARDS. Renamed to "The layout job passed" and LAYOUT, in the workflow and the two tests
that read them. The required check's name is unchanged.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant