Skip to content

Expose mknodat/mkfifoat on Apple targets - #1625

Merged
sunfishcode merged 2 commits into
bytecodealliance:mainfrom
mattsu2020:mknodat_macos
Nov 10, 2026
Merged

Expose mknodat/mkfifoat on Apple targets#1625
sunfishcode merged 2 commits into
bytecodealliance:mainfrom
mattsu2020:mknodat_macos

Conversation

@mattsu2020

@mattsu2020 mattsu2020 commented May 16, 2026 •
edited
Loading

Copy link
Copy Markdown

Summary

  • Expose mknodat and mkfifoat on Apple targets.
  • Weak-link mknodat on Apple and return NOSYS when unavailable on older systems.
  • Document the supported Apple OS versions and behavior on older systems for both public APIs.

Closes #1691

@mattsu2020 mattsu2020 mentioned this pull request May 16, 2026
Draft
@oech3 oech3 mentioned this pull request May 17, 2026
Merged
@xtqqczze

This comment was marked as resolved.

Sign in to view
@oech3

This comment was marked as outdated.

Sign in to view
@xtqqczze

This comment was marked as resolved.

Sign in to view
@mattsu2020

This comment was marked as resolved.

Sign in to view
@xtqqczze

This comment was marked as resolved.

Sign in to view
xtqqczze
xtqqczze reviewed May 17, 2026
View reviewed changes
Comment thread src/backend/libc/fs/syscalls.rs Resolved
@mattsu2020
mattsu2020 requested a review from xtqqczze June 30, 2026 09:27
xtqqczze
xtqqczze reviewed Jun 30, 2026
View reviewed changes
Comment thread src/backend/libc/fs/syscalls.rs Resolved
@xtqqczze

This comment was marked as outdated.

Sign in to view
@oech3

This comment was marked as duplicate.

Sign in to view
xtqqczze
xtqqczze reviewed Aug 6, 2026
View reviewed changes
Comment thread src/backend/libc/fs/syscalls.rs Resolved
@badeend

badeend commented Aug 25, 2026

Copy link
Copy Markdown
Member

@mattsu2020 The fix for the CI failure #1620 has been merged. Could you update this PR?

@mattsu2020

This comment was marked as resolved.

Sign in to view
@badeend

badeend commented Aug 28, 2026

Copy link
Copy Markdown
Member

@sunfishcode Could you take a look at this? The code change seems relatively straightforward, and it passes CI.

@oech3

This comment was marked as resolved.

Sign in to view
@mattsu2020

This comment was marked as resolved.

Sign in to view
@xtqqczze

This comment was marked as resolved.

Sign in to view
mattsu2020 added a commit to mattsu2020/rustix that referenced this pull request Sep 19, 2026
@mattsu2020
[feat: expose mknodat/mkfifoat on Apple targets (bytecodealliance#1625)]
c9532b1 
macOS 13 and corresponding Apple platforms added mknodat/mkfifoat.
These APIs were previously excluded with cfg(not(apple)).

On Apple, resolve mknodat at runtime with the same weak-linking
pattern used for linkat/unlinkat/renameat. If the symbol is absent
(macOS < 13 and older Apple OS variants), return NOSYS so a binary
built against a newer SDK can still run on older systems. Other
targets keep calling libc mknodat directly. mkfifoat goes through
the same path.

Also import Dev and FileType on Apple so the public wrappers
compile, add XNU man-page references, and shrink the unsafe block
around the syscall.
@mattsu2020

This comment was marked as resolved.

Sign in to view
xtqqczze

This comment was marked as resolved.

Sign in to view

mattsu2020 added a commit to mattsu2020/rustix that referenced this pull request Sep 19, 2026
@mattsu2020
Expose mknodat and mkfifoat on Apple targets (bytecodealliance#1625)
3835644 
Weak-link mknodat on Apple and return NOSYS when unavailable on older
systems. Keep direct libc calls on other targets.

Document availability starting in macOS 13.0, iOS 16.0, tvOS 16.0,
and watchOS 9.0 for both APIs.
@mattsu2020

This comment was marked as resolved.

Sign in to view
@xtqqczze

This comment was marked as resolved.

Sign in to view
@mattsu2020
Expose mknodat and mkfifoat on Apple targets
cdce881 
Weak-link mknodat on Apple and return NOSYS when unavailable on older
systems. Keep direct libc calls on other targets.
@mattsu2020

This comment was marked as resolved.

Sign in to view
@mattsu2020

This comment was marked as resolved.

Sign in to view
@xtqqczze

This comment was marked as resolved.

Sign in to view
@mattsu2020

This comment was marked as resolved.

Sign in to view
@mattsu2020
mattsu2020 requested a review from xtqqczze September 28, 2026 10:01
xtqqczze

This comment was marked as resolved.

Sign in to view

@mattsu2020

This comment was marked as resolved.

Sign in to view
@xtqqczze

This comment was marked as resolved.

Sign in to view
@xtqqczze

This comment was marked as resolved.

Sign in to view
@mattsu2020
mattsu2020 requested a review from xtqqczze October 9, 2026 12:58
@xtqqczze

xtqqczze commented Oct 15, 2026

Copy link
Copy Markdown
Contributor

@sunfishcode Would appreciate it if you could take a look at this one.

@mattsu2020
Merge upstream main into mknodat_macos
4c22c36 
Resolve reference-link conflicts in mknodat and mkfifoat documentation, preserving Apple, Linux, and FreeBSD references.
@sunfishcode
sunfishcode merged commit ffa6ee5 into bytecodealliance:main Nov 10, 2026
50 of 51 checks passed
@sunfishcode

sunfishcode commented Nov 10, 2026

Copy link
Copy Markdown
Member

Thanks!

@mattsu2020
mattsu2020 deleted the mknodat_macos branch November 10, 2026 21:46
@xtqqczze xtqqczze mentioned this pull request Nov 14, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@xtqqczze xtqqczze xtqqczze approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support mknodat/mkfifoat on Apple targets

5 participants

@mattsu2020 @xtqqczze @oech3 @badeend @sunfishcode