Skip to content

feat: added new Server/wire versions - #255

Merged
bwaldvogel merged 1 commit into
bwaldvogel:mainfrom
jmarkerink:feat/added-server-versions
Nov 14, 2026
Merged

bwaldvogel merged 1 commit into
bwaldvogel:mainfrom
jmarkerink:feat/added-server-versions

Conversation

@jmarkerink

Copy link
Copy Markdown

private final Map<String, MongoDatabase> databases = new ConcurrentHashMap<>();

private MongoVersion version = ServerVersion.MONGO_5_0;
private MongoVersion version = ServerVersion.MONGO_4_2;

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this an intentional change?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, so we stay on the same wire version.

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current default version is 5.0. Why should we change it to 4.2?

@jmarkerink jmarkerink Nov 12, 2026 •

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The previous code was MONGO_5_0(List.of(5, 0, 0), 8) which is incorrect. So I aligned the default server version with the same wireVersion to avoid the bump from 8 to 13.

Should I change it?

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clarification. You're right that the current server version and wire version are inconsistent. Resolving this may affect client behavior either way. I'd therefore prefer to move the default forward to a more recent major version, such as 7.0, 8.0 or even 9.0, rather than downgrade it from 5.0 to 4.2.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added more versions and used the lowest version which is not EOL as default.

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jmarkerink
jmarkerink force-pushed the feat/added-server-versions branch from 73ff1c8 to 2e05833 Compare November 14, 2026 13:42
@bwaldvogel
bwaldvogel merged commit a5b9def into bwaldvogel:main Nov 14, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants