Repository navigation
feat: added new Server/wire versions - #255
Conversation
| private final Map<String, MongoDatabase> databases = new ConcurrentHashMap<>(); | ||
|
|
||
| private MongoVersion version = ServerVersion.MONGO_5_0; | ||
| private MongoVersion version = ServerVersion.MONGO_4_2; |
There was a problem hiding this comment.
Is this an intentional change?
There was a problem hiding this comment.
Yes, so we stay on the same wire version.
There was a problem hiding this comment.
The current default version is 5.0. Why should we change it to 4.2?
There was a problem hiding this comment.
The previous code was MONGO_5_0(List.of(5, 0, 0), 8) which is incorrect. So I aligned the default server version with the same wireVersion to avoid the bump from 8 to 13.
Should I change it?
There was a problem hiding this comment.
Thanks for the clarification. You're right that the current server version and wire version are inconsistent. Resolving this may affect client behavior either way. I'd therefore prefer to move the default forward to a more recent major version, such as 7.0, 8.0 or even 9.0, rather than downgrade it from 5.0 to 4.2.
There was a problem hiding this comment.
Added more versions and used the lowest version which is not EOL as default.
73ff1c8 to
2e05833
Compare
added and corrected: Server / wire versions conform: https://github.com/mongodb/specifications/blob/master/source/wireversion-featurelist/wireversion-featurelist.md