Repository navigation
feat: brainpod storage providers - #23
Merged
Merged
Conversation
jeroenrinzema
requested review from
dmeijboom
and
a balanced review from Copilot
November 15, 2026 19:21
jeroenrinzema
enabled auto-merge
November 15, 2026 19:21
There was a problem hiding this comment.
🟡 Changes recommended
The embedded OpenAPI schema omits Bucket, causing the documented bucket describe command to fail with unknown resource kind when the remote specification is unavailable.
1 open issue
What changed in this PR
Adds storage-provider discovery to the Brainpod CLI so users and agents can choose Bucket providers and regions without guessing. This depends on the companion API endpoint change.
Changes:
- Adds
brainpod storage providerswith table and JSON output. - Extends embedded OpenAPI metadata and adds Bucket guidance to resource descriptions.
- Updates documentation and adds parsing, rendering, and guidance tests.
| File | Description |
|---|---|
src/output.rs |
Renders provider tables and resource notes; adds rendering tests. |
src/openapi.rs |
Adds Bucket-specific notes to resource descriptions and tests the guidance. |
src/openapi.json |
Defines the storage-provider endpoint, schemas, and tag. |
src/main.rs |
Tests command parsing and client requirements. |
src/describe.rs |
Classifies provider discovery as an authenticated read and updates next steps. |
src/cmd/mod.rs |
Defines and dispatches the storage-provider command. |
README.md |
Documents provider discovery and Bucket field guidance. |
Review effort: Balanced
dmeijboom
approved these changes
Nov 15, 2026
- Refresh the embedded OpenAPI from production (adds Bucket and MSSQL to ResourceInput) while keeping /v1/storage/providers - Test that the embedded fallback lists Bucket
jeroenrinzema
force-pushed
the
feat/storage-providers
branch
from
November 15, 2026 19:45
e2ba5f6 to
1f46ab3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Adds
brainpod storage providers, which calls the newGET /v1/storage/providers(listStorageProviders) endpoint and listsKEY NAME REGIONS. With--jsonit prints the returned array.Why: a Bucket's
spec.providerandspec.regionare installation data. Until now they were only exposed through the console's tRPC, so agents had to guess them. An onboarding run used all 200 of its tool calls on this./v1/storage/providersplus theStorageProvider/StorageProviderListschemas and astoragetag.brainpod describe resource <kind>returnsnotes, and the text view shows them. For Bucket, the note points tobrainpod storage providers.describe resource createnext steps now mentionbrainpod storage providers.describealso classifies the new command as an authenticated read.The API endpoint is added in brainpodnl/brainpod in the same change (feat/onboarding-planner-loop). Merge this PR together with that one.