Skip to content

feat: brainpod storage providers - #23

Merged
jeroenrinzema merged 2 commits into
mainfrom
feat/storage-providers
Nov 15, 2026
Merged

jeroenrinzema merged 2 commits into
mainfrom
feat/storage-providers

Conversation

@jeroenrinzema

Copy link
Copy Markdown
Collaborator

Adds brainpod storage providers, which calls the new GET /v1/storage/providers (listStorageProviders) endpoint and lists KEY NAME REGIONS. With --json it prints the returned array.

Why: a Bucket's spec.provider and spec.region are installation data. Until now they were only exposed through the console's tRPC, so agents had to guess them. An onboarding run used all 200 of its tool calls on this.

  • The embedded OpenAPI now includes /v1/storage/providers plus the StorageProvider/StorageProviderList schemas and a storage tag.
  • brainpod describe resource <kind> returns notes, and the text view shows them. For Bucket, the note points to brainpod storage providers.
  • describe resource create next steps now mention brainpod storage providers. describe also classifies the new command as an authenticated read.
  • README updated. Added tests for parsing, text rendering and the Bucket note.

The API endpoint is added in brainpodnl/brainpod in the same change (feat/onboarding-planner-loop). Merge this PR together with that one.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The embedded OpenAPI schema omits Bucket, causing the documented bucket describe command to fail with unknown resource kind when the remote specification is unavailable.

1 open issue
What changed in this PR

Adds storage-provider discovery to the Brainpod CLI so users and agents can choose Bucket providers and regions without guessing. This depends on the companion API endpoint change.

Changes:

  • Adds brainpod storage providers with table and JSON output.
  • Extends embedded OpenAPI metadata and adds Bucket guidance to resource descriptions.
  • Updates documentation and adds parsing, rendering, and guidance tests.
File Description
src/​output.rs Renders provider tables and resource notes; adds rendering tests.
src/​openapi.rs Adds Bucket-specific notes to resource descriptions and tests the guidance.
src/​openapi.json Defines the storage-provider endpoint, schemas, and tag.
src/​main.rs Tests command parsing and client requirements.
src/​describe.rs Classifies provider discovery as an authenticated read and updates next steps.
src/​cmd/​mod.rs Defines and dispatches the storage-provider command.
README.md Documents provider discovery and Bucket field guidance.

Review effort: Balanced

Comment thread src/openapi.json Resolved
- Refresh the embedded OpenAPI from production (adds Bucket and MSSQL to ResourceInput) while keeping /v1/storage/providers
- Test that the embedded fallback lists Bucket
@jeroenrinzema
jeroenrinzema added this pull request to the merge queue Nov 15, 2026
Merged via the queue into main with commit 5947ec0 Nov 15, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants