Repository navigation
Conversation
Per the spec, pagination links can be omitted https://jsonapi.org/format/#fetching-pagination > Keys MUST either be omitted or have a null value to indicate that a particular link is unavailable.
Member
|
Can you add a new test next to existing pagination tests that uses a new test paginator that returns some but not all links to make sure we aren't making any assumptions about any of the link keys anywhere? Ideally the new test code would loop over each link key and omit them one at a time via macro (effectively one test per link key without taking up so much space). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there,
Seems that per the spec, pagination links can be omitted
https://jsonapi.org/format/#fetching-pagination
There seems to be no reason to be so strict about the returned links by
paginatecallback?Because of this we have a failing dialyzer check.
Thank you