Repository navigation
Conversation
The Electron matrix build was called from build-and-deploy, so its failures turned the web deploy run red. Trigger electron.yml directly on push/PR to main instead, so the web/.NET pipeline is independent of it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #673 +/- ##
========================================
- Coverage 4.74% 4.73% -0.02%
========================================
Files 195 196 +1
Lines 10199 10228 +29
Branches 322 323 +1
========================================
Hits 484 484
- Misses 9535 9563 +28
- Partials 180 181 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The Electron matrix build (macOS / Ubuntu / Windows) was called from
build-and-deploy.ymlviaworkflow_call, so a failing Electron build marked the whole web deploy run as failed.Changes
build-and-deploy.yml: remove thebuild-electron-appjob.electron.yml: trigger directly on push tomainand PRs tomain(plus manualworkflow_dispatch). Same conditions as before: it skips closed PRs (the defaultpull_requesttypes) and runs that don't have secrets (Dependabot / forks).Testing
🤖 Generated with Claude Code