Skip to content

ci: run Electron build as its own workflow - #673

Open
KillerX wants to merge 1 commit into
mainfrom
ci/separate-electron-workflow
Open

KillerX wants to merge 1 commit into
mainfrom
ci/separate-electron-workflow

Conversation

@KillerX

@KillerX KillerX commented Nov 2, 2026

Copy link
Copy Markdown
Member

Why

The Electron matrix build (macOS / Ubuntu / Windows) was called from build-and-deploy.yml via workflow_call, so a failing Electron build marked the whole web deploy run as failed.

Changes

  • build-and-deploy.yml: remove the build-electron-app job.
  • electron.yml: trigger directly on push to main and PRs to main (plus manual workflow_dispatch). Same conditions as before: it skips closed PRs (the default pull_request types) and runs that don't have secrets (Dependabot / forks).

Testing

  • Both workflow files parse as valid YAML.
  • On this PR, the Electron build should show up as a separate "Build electron app" run.

🤖 Generated with Claude Code

The Electron matrix build was called from build-and-deploy, so its
failures turned the web deploy run red. Trigger electron.yml directly on
push/PR to main instead, so the web/.NET pipeline is independent of it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@codecov

codecov Bot commented Nov 2, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 4.73%. Comparing base (73bd04b) to head (a23013c).
⚠️ Report is 13 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##            main    #673      +/-   ##
========================================
- Coverage   4.74%   4.73%   -0.02%     
========================================
  Files        195     196       +1     
  Lines      10199   10228      +29     
  Branches     322     323       +1     
========================================
  Hits         484     484              
- Misses      9535    9563      +28     
- Partials     180     181       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant