Repository navigation
fix: validate RFT rewards before reporting rollout success - #6572
Open
luyuzhe111 wants to merge 1 commit into
Open
luyuzhe111 wants to merge 1 commit into
luyuzhe111 wants to merge 1 commit into
Conversation
luyuzhe111
requested a deployment
to
manual-approval
November 7, 2026 00:11 — with
GitHub Actions
Waiting
luyuzhe111
requested a deployment
to
manual-approval
November 7, 2026 00:11 — with
GitHub Actions
Waiting
luyuzhe111
requested a deployment
to
manual-approval
November 7, 2026 00:11 — with
GitHub Actions
Waiting
Author
|
cc @992X @SifeiLi for review. issue identified by @qingliz in awslabs/agentcore-rl-toolkit#209 |
992X
approved these changes
Nov 7, 2026
SifeiLi
approved these changes
Nov 9, 2026
This branch is waiting to be deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sagemaker_rft_handlercurrently reports dictionary results without a reward asreadywithout submitting a reward. Invalid reward values can also triggerreadybefore reward submission fails.Validate rewards before reporting success. Accept finite integers and floats, or non-empty lists of those values; reject missing values,
None, booleans, non-numeric values, and non-finite floats. Invalid rewards use the existingreport_errorpath to reportfailedwith reward 0. The handler's return value, expliciterror/skippedhandling, public signatures, and feedback exception policy remain unchanged.This tightens automatic reporting: a decorated handler that manually reports feedback but returns a dictionary without a valid reward will now also attempt to report
failed.Validation