Repository navigation
fix: preserve AgentCore context in RFT handlers - #6571
Open
luyuzhe111 wants to merge 1 commit into
Open
luyuzhe111 wants to merge 1 commit into
luyuzhe111 wants to merge 1 commit into
Conversation
luyuzhe111
requested a deployment
to
manual-approval
November 6, 2026 23:41 — with
GitHub Actions
Waiting
luyuzhe111
requested a deployment
to
manual-approval
November 6, 2026 23:41 — with
GitHub Actions
Waiting
luyuzhe111
requested a deployment
to
manual-approval
November 6, 2026 23:41 — with
GitHub Actions
Waiting
Author
|
cc @992X @SifeiLi for review. issue identified by @qingliz in awslabs/agentcore-rl-toolkit#209 |
992X
approved these changes
Nov 7, 2026
SifeiLi
approved these changes
Nov 9, 2026
This branch is waiting to be deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix
sagemaker_rft_handlerfailing when an AgentCore entrypoint accepts(payload, context). The SageMaker integration guide requires applying this decorator to AgentCore entrypoints. The official AgentCore Python SDK supports the context parameter and covers it in both sync and async tests.For example:
AgentCore uses
inspect.signature()to decide whether to pass the request context. Because the RFT decorator usesfunctools.wraps, inspection exposes the original two-argument signature, but the wrapper accepts onlypayload. Invoking the example therefore returns HTTP 500 withTypeError: invoke() takes 1 positional argument but 2 were given, before the handler or rollout feedback logic runs.Forward additional positional and keyword arguments through both RFT wrappers while retaining
wraps. This lets AgentCore supply the context and preserves existing single-argument handlers. Add unit coverage for sync/async handlers, positional and keyword context forwarding, feedback reporting, and rollout context cleanup. Update the decorator's argument documentation and correct its name in the existing example.Validation
pytest sagemaker-train/tests/unit/train/test_rft_decorators.py: 8 passed.BedrockAgentCoreApp, with feedback HTTP requests mocked: sync and async context handlers fail before the fix and succeed after it.