Repository navigation
fix(mlops): keep S3CompressionType/S3DataDistributionType in ClarifyCheckStep inputs - #6421
Closed
AkshayShah03 wants to merge 1 commit into
Closed
AkshayShah03 wants to merge 1 commit into
AkshayShah03 wants to merge 1 commit into
Conversation
…heckStep inputs ClarifyCheckStep builds the dataset ProcessingInput with s3_compression_type and s3_data_distribution_type from the DataConfig, but ClarifyCheckStep.arguments only serialized S3Uri, LocalPath, S3DataType and S3InputMode. A DataConfig(s3_compression_type='Gzip') therefore produced a processing job without S3CompressionType, so the gzipped dataset reached the Clarify container still compressed. Serialize both fields when they are set, as core's SageMakerClarifyProcessor does.
AkshayShah03
had a problem deploying
to
manual-approval
October 10, 2026 01:55 — with 
GitHub Actions
Failure
GitHub Actions
Failure
AkshayShah03
had a problem deploying
to
manual-approval
October 10, 2026 01:55 — with
GitHub Actions
Failure
GitHub Actions
Failure
AkshayShah03
had a problem deploying
to
manual-approval
October 10, 2026 01:55 — with
GitHub Actions
Failure
GitHub Actions
Failure
Author
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available: N/A
Description of changes:
ClarifyCheckStepbuilds its datasetProcessingInputwiths3_compression_typeands3_data_distribution_typetaken from theDataConfig. However,ClarifyCheckStep.argumentsserializes onlyS3Uri,LocalPath,S3DataTypeandS3InputMode.So
DataConfig(..., s3_compression_type="Gzip")in aClarifyCheckStepproduces a processing job withoutS3CompressionType, and the gzipped dataset reaches the Clarify container still compressed. Core'sSageMakerClarifyProcessorpasses both fields through.This change serializes
S3DataDistributionTypeandS3CompressionTypewhen they're set, and skipsNoneor unassigned values.Testing:
test_dataset_compression_and_distribution_type_propagated. It fails before this change.sagemaker-mlops/tests/unit/workflow: 360 passed.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.