Repository navigation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #653 +/- ##
=======================================
Coverage 82.04% 82.04%
=======================================
Files 37 37
Lines 1487 1487
=======================================
Hits 1220 1220
Misses 264 264
Partials 3 3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Add the event type CloudWatch sends when a Lambda function is configured directly as an alarm action. Covers metric alarms, composite alarms, and alarm tags. Timestamps are strings because CloudWatch uses a +0000 offset that time.Time cannot parse, matching CloudWatchAlarmSNSPayload. Fixes aws#555
nakultt
force-pushed
the
events/cloudwatch-alarm-lambda-event
branch
from
October 28, 2026 09:02
8c2ae73 to
d9e337c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #555
Description of changes:
Adds
events.CloudWatchAlarmEvent, the payload CloudWatch sends when a Lambda function is configured directly as an alarm action (docs). The existingCloudWatchAlarmSNSPayloadonly covers the SNS-delivered format.configuration.metricswithmetricStat(namespace, name, dimensions, period, stat, unit) andreturnDataalarmRule,actionsSuppressor, wait/extension periods, andactionsSuppressedBy/actionsSuppressedReasonon the statealarmTagsandalarmTagsStatusNotes:
stringbecause CloudWatch uses a+0000offset (e.g.2023-08-04T12:36:15.490+0000) thattime.Timecan't unmarshal. This matchesCloudWatchAlarmSNSPayload.StateChangeTime.reasonDatastays a JSON-encoded string, as delivered by CloudWatch.CloudWatchAlarmprefix to avoid clashing with the SNS payload types (CloudWatchMetric,CloudWatchMetricStat, ...), which use PascalCase JSON keys.Testing: the fixtures are the documented metric and composite alarm example events. The tests round-trip both through
json.Unmarshal/json.Marshaland check key fields, plus the malformed-JSON check.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.