Repository navigation
Fix/own account cleanup - #962
Merged
Merged
Conversation
java-performance.sh and java-on-amazon-eks.sh stop every StatefulSet and Deployment that mounts a PersistentVolumeClaim, delete the claims and wait until their PersistentVolumes are gone. Without this, the gp3 volumes of Prometheus, Grafana and Pyroscope (28 GiB) stayed billed as `available` after the stack was deleted. Stopping Pyroscope also ends its writes into the workshop bucket, which failed the bucket's deletion. The plan shows the claim count. All three cleanup scripts define log_success: the final report_stack_retained called it and exited 127 after a successful cleanup.
…n the enforce block The reports controller of Kyverno v1.19.1 can stop producing reports without an error (kyverno#17848; the counter fix kyverno#17085 is only in the 1.20 release candidates). The enforce block of the content now restarts it after 90 s without a PolicyReport. The comment at the chart pin says to bump it and drop the restart once a stable release has the fix. ws-test regenerated from the content (the own-account setup blocks are test=false and only shift line numbers).
Every Lambda function, the CodeBuild project and the IDE bootstrap log to a log group the stack owns (Lambda.stackLogGroup: generated name, 7 days, RemovalPolicy.DESTROY). Before, Lambda, CodeBuild and the CloudWatch agent created their own groups (/aws/lambda/..., /aws/codebuild/..., workshop-ide-bootstrap-<date>), and nine of them outlived the stack. CloudFormation deletes each group after the resource that writes to it, so the logs of the custom resources' Delete calls go too. A generated name keeps a group left by an earlier deployment from blocking the create. Only the java-performance stack is regenerated (GIT_BRANCH=main); the other workshops pick this up at their next generation.
ybezsonov
added a commit
that referenced
this pull request
Nov 10, 2026
…nc with java-performance (#963) The CON405 content gets the same changes as java-performance: the own-account setup tab, the cleanup page and the enforce block's restart of a stalled Kyverno reports controller (kyverno#17848). Here: the comment at the Kyverno pin, the ws-test regenerated from the content, and the stack regenerated (GIT_BRANCH=main) with the stack-owned log groups of #962. The two workshops' deploy scripts, stacks and ws-tests differ only in the name again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.