Repository navigation
Decode SLIP packets across TCP stream boundaries - #203
Open
civilwarinfrance wants to merge 1 commit into
Open
civilwarinfrance wants to merge 1 commit into
civilwarinfrance wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The SLIP stream decoder currently looks for two adjacent END bytes between packets. A valid stream with just one END between packets fails to decode, and splitting an encoded message across TCP reads can produce empty packets.
Scan individual END markers, skip empty frames, and keep incomplete packet bytes for the next read. Tests cover single-END streams, repeated delimiters, every two-part split and byte-by-byte delivery, including escaped END and ESC bytes.
All 201 tests pass locally, along with Ruff, mypy and the package build.
AI assistance: OpenAI Codex wrote and tested this patch.