Repository navigation
Handle invalid UTF-8 as an OSC parse error - #202
Open
civilwarinfrance wants to merge 1 commit into
Open
civilwarinfrance wants to merge 1 commit into
civilwarinfrance wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Malformed UTF-8 in an OSC address, type tag or string argument currently raises UnicodeDecodeError. This escapes the parse-error handling in the dispatcher instead of discarding the packet.
Convert decoding errors to the existing osc_types.ParseError. Tests cover malformed byte sequences, valid Unicode with a nonzero offset, and discarding malformed packets before successfully dispatching a valid one.
Validation: 195 tests pass; Ruff lint/format, mypy and package build pass locally. The new regression cases fail on the original code. Hosted CI is pending.
AI assistance: OpenAI Codex wrote and tested this patch.