Repository navigation
docs: Build the character creator on the headless Creator API - #29
Merged
Merged
Conversation
The client dropped Creator.open, isOpen and close and the creatorOpened, creatorConfirmed and creatorCancelled events (arcane-mp/mod 5bd71520). The appearance guide now builds the creator on begin, applyPatch and commit, the events table loses the three events, and the time-and-weather sample sets its sky from a resource's own creator.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
arcane-mp/mod5bd71520 (UI: Drop the hosted HUD and creator pages) removed the client's built-in creator screen:Creator.open,Creator.isOpenandCreator.close;creatorOpened,creatorConfirmedandcreatorCancelledevents.Foundations builds its own creator on the headless API. The appearance guide's sample still called
Creator.open(), so every mod PR's "Scripting type-check" fails on this repo's samples.begin(check its result),getSchema,applyPatchwithcreatorChanged, thencommitorcancel;CreatorPreviewandexportLook;playerAppearanceChanged, ascommit()'s own description says.creatorChangedstays.Checked locally:
arcane-mp/mod'scheck_docs_samples.mjstype-checks all 294 samples in 63 guides against currentmain's contract. The site build and link check run here in CI. Locally,docs.mjscan't startpnpmon Windows.