Repository navigation
perf: Resume a paced crawl as soon as the request manager's ready_at passes - #2393
Merged
Merged
Conversation
Mantisus
marked this pull request as ready for review
November 3, 2026 22:37
vdusek
reviewed
Nov 5, 2026
ready_atready_at passes
Mantisus
force-pushed
the
crawler-run-wake
branch
from
November 5, 2026 17:09
c228944 to
a4d6b73
Compare
Mantisus
force-pushed
the
crawler-run-wake
branch
from
November 5, 2026 20:26
a4d6b73 to
5dc2f20
Compare
ready_at passesready_at passes
vdusek
approved these changes
Nov 6, 2026
vdusek
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, I just changed the title to perf, since this doesn't add new functionality or touch the public API.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When the request manager reports
waitingwith aready_at, the crawler schedules a wake-up for that moment, so a paced crawl resumes on the manager's clock instead of on the autoscaled pool's next poll. This tightens the dispatch cadence forThrottlingRequestManagercooldowns and crawl-delays. Only the earliest pendingready_atis kept, and a pending wake-up is dropped when the run ends.Issues
is_empty/is_finishedwithcheck_readiness()and add pacing signals toRequestManager#2296AutoscaledPoolimmediately withnotify()#2386✍️ Drafted by Claude Code