Repository navigation
Conversation
ede9eef to
e7702f5
Compare
81cd71a to
eb97ca8
Compare
e7702f5 to
d24acf9
Compare
c4b212f to
3b6ce15
Compare
There was a problem hiding this comment.
Warning
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Copilot review overview
4 open issues
nodeIdAttributesis declared in this header with astd::mapreturn type, but<map>is not… · Newstd::ignorerequires including<tuple>. As written, this header may fail to compile in… · New Write failures (output_stream->writereturning an error) are not handled aftersession.write… · NewClient::findChildsilently returns the first target even when multiple targets match the browse… · New
What changed in this PR
Adds the new FetchOPCFile OPC UA processor and supporting test infrastructure to enable fetching file contents from OPC UA FileType nodes (including optional “lazy” change detection).
Changes:
- Introduces
FetchOPCFileprocessor implementation plus shared OPC UA file-transfer utilities. - Adds extensive unit + behave/E2E test coverage (including an OPC UA file server container/image).
- Updates processor documentation and the generated docker manifest reference.
| File | Description |
|---|---|
| extensions/opc/tests/features/steps/steps.py | Adds Behave steps for provisioning an OPC UA file server and populating files. |
| extensions/opc/tests/features/resources/opcua-file-server/file_server.cpp | Implements a lightweight open62541-based OPC UA file server exposing /data as FileType nodes. |
| extensions/opc/tests/features/resources/opcua-file-server/Dockerfile | Builds the OPC UA file server image used by Behave scenarios. |
| extensions/opc/tests/features/opcua_file_transfer.feature | Adds E2E scenario validating FetchOPCFile against the file server container. |
| extensions/opc/tests/features/containers/opc_ua_file_server_container.py | Adds a dedicated test container wrapper for the OPC UA file server. |
| extensions/opc/tests/OpcUaTestServer.h | Extends the in-process test server with FileType-like nodes and method callbacks. |
| extensions/opc/tests/FetchOPCFileTests.cpp | Adds comprehensive unit tests for FetchOPCFile behavior and edge cases. |
| extensions/opc/src/OPCFileTransfer.cpp | Implements RemoteFile Open/Read/Close interactions and chunking behavior. |
| extensions/opc/src/OPCCommon.cpp | Adds reusable helpers (nodeIdAttributes, method calls, browse name/scalar reads, findChild). |
| extensions/opc/src/FetchOPCFile.cpp | Implements the new FetchOPCFile processor logic, caching, and lazy-mode state handling. |
| extensions/opc/include/OPCFileTransfer.h | Declares RemoteFile/RemoteFileHandle and chunk wrapper types. |
| extensions/opc/include/OPCCommon.h | Declares MethodOutput and new Client helper APIs + nodeIdAttributes. |
| extensions/opc/include/FetchOPCFile.h | Declares FetchOPCFile properties/relationships/attributes and internal state. |
| README.md | Updates extension processor list to include FetchOPCEvents and FetchOPCFile. |
| PROCESSORS.md | Documents FetchOPCFile processor properties/relationships/output attributes. |
| .github/references/docker_manifest.json | Adds the FetchOPCFile processor metadata entry used by the docker manifest reference. |
Review effort: Lite
3b6ce15 to
95b2a31
Compare
d24acf9 to
bc962f5
Compare
95b2a31 to
2c6614b
Compare
bc962f5 to
302fdf3
Compare
2c6614b to
34c6c98
Compare
302fdf3 to
935d18a
Compare
34c6c98 to
81fe7a1
Compare
81fe7a1 to
e3f5cb8
Compare
| | Certificate path | | | Path to the DER-encoded cert file | | ||
| | Key path | | | Path to the DER-encoded key file | |
There was a problem hiding this comment.
Normally we use PEM, can we support both PEM and DER?
There was a problem hiding this comment.
Originally we only used DER key format for the initial processors, but from what I see in the open62541 library PEM is also supported with and without password. As the PEM keys are also converted to DER format in the library, and from what I see in the git logs, PEM support was probably added later than the first introduced OPC UA processors, that is why it was not supported before. We can add the support for it, but as this is a common feature that affects all processors I would handle it separately, I created a new jira for it: https://issues.apache.org/jira/browse/MINIFICPP-2953


https://issues.apache.org/jira/browse/MINIFICPP-2927
Depends on #2268
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically main)?
Is your initial contribution a single, squashed commit?
For code changes:
For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.