Skip to content

Drop unused variable in extended_protocol_resqueue - #2199

Merged
tuhaihe merged 1 commit into
apache:mainfrom
tuhaihe:fix-resqueue-test-unused-var
Nov 10, 2026
Merged

tuhaihe merged 1 commit into
apache:mainfrom
tuhaihe:fix-resqueue-test-unused-var

Conversation

@tuhaihe

@tuhaihe tuhaihe commented Oct 27, 2026

Copy link
Copy Markdown
Member

paramValues is declared and never used. The GNUmakefile builds extended_protocol_resqueue without the usual warning flags, so nothing has reported it; with -Wall the compiler warns about it.

Assisted-by: Claude Code

Fixes #ISSUE_Number

What does this PR do?

Type of Change

  • Bug fix (non-breaking change)
  • New feature (non-breaking change)
  • Breaking change (fix or feature with breaking changes)
  • Documentation update

Breaking Changes

Test Plan

  • Unit tests added/updated
  • Integration tests added/updated
  • Passed make installcheck
  • Passed make -C src/test installcheck-cbdb-parallel

Impact

Performance:

User-facing changes:

Dependencies:

Checklist

Additional Context

CI Skip Instructions


@tuhaihe tuhaihe added this to the 3.0 milestone Oct 27, 2026
@tuhaihe

tuhaihe commented Oct 27, 2026

Copy link
Copy Markdown
Member Author

We found this issue in #1940.

@tuhaihe tuhaihe modified the milestones: 3.0, 3.x Meson Oct 27, 2026

@leborchuk leborchuk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Alena0704 Alena0704 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tuhaihe
tuhaihe force-pushed the fix-resqueue-test-unused-var branch from 37145cc to 592a693 Compare November 9, 2026 14:40
@tuhaihe
tuhaihe enabled auto-merge (rebase) November 9, 2026 14:40
paramValues is declared and never used. The GNUmakefile builds
extended_protocol_resqueue without the usual warning flags, so nothing
has reported it; with -Wall the compiler warns about it.

Assisted-by: Claude Code
@tuhaihe
tuhaihe force-pushed the fix-resqueue-test-unused-var branch from 592a693 to 91f233a Compare November 10, 2026 02:39
@tuhaihe
tuhaihe merged commit 18cbbcc into apache:main Nov 10, 2026
122 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants