Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Design Notes
The table compares the public futures immediately before and after the Condvar commit. Both rustc 1.86.0 and 1.101.0-nightly (
8006091eb) produced these values onaarch64-apple-darwin. The probe used a release build with only thecondvarfeature and calledsize_of_valon the unboxed futures returned with borrowed and owned guards forMutex<()>.ca794f7)55d4ab9)Condvar::waitCondvar::wait_ownedOn the same nightly target, the read-permit change also reduces
RwLock::readandread_ownedfutures from 48 B to 32 B, andUpgradableRwLock::upgradable_readfrom 56 B to 48 B.Validation passed with
cargo x teston Rust 1.86.0 and nightly (707 tests each),cargo x check(26 feature configurations),cargo x lint, and the ecosystem, primitives, and upgradable-lock stage benchmark smoke checks.The additional Linux-target Miri run passed all 11 Condvar integration tests with
-Zmiri-ignore-leaks. The shared Tokio test runtime keeps worker threads alive at process exit on both sides of the Condvar change. The repository's standard Miri suite runs separately in CI with its normal leak checks.