Repository navigation
refactor: share waiter lifecycles and simplify value ownership - #431
Merged
Merged
Conversation
Keep the waiter token and its cancellation cleanup alongside the countdown state. Both primitives use the same lock-free completion check and locked registration path.
MPMC receivers and SPMC operations rejoin the queue after a notification if the resource is gone. Keep registration and notification together while MPMC capacity grants retain their own ownership rules.
Collect the compacted suffix directly into the returned vector after all predicates have completed, avoiding a temporary deque under the pool lock.
Taking the value clears the publication flag before moving it out, so the normal destructor already handles a consumed cell.
Completion and abandonment both detach observers before exposing the result to lock-free readers. Return the waiter set so callbacks run after unlocking.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary