Skip to content

GH-1455: Keep TestReservationListener from closing a pool still in use #1457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jbonofre merged 1 commit into from
Nov 10, 2026
Merged

GH-1455: Keep TestReservationListener from closing a pool still in use #1457

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions dataset/src/test/java/org/apache/arrow/dataset/TestDataset.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,12 +68,9 @@ protected BufferAllocator rootAllocator() {

protected List<ArrowRecordBatch> collectResultFromFactory(
DatasetFactory factory, ScanOptions options) {
final Dataset dataset = factory.finish();
final Scanner scanner = dataset.newScan(options);
try {
final List<ArrowRecordBatch> ret = collectTaskData(scanner);
AutoCloseables.close(scanner, dataset);
return ret;
try (Dataset dataset = factory.finish();
Scanner scanner = dataset.newScan(options)) {
return collectTaskData(scanner);
} catch (RuntimeException e) {
throw e;
} catch (Exception e) {
Expand Down
6 changes: 3 additions & 3 deletions dataset/src/test/java/org/apache/arrow/dataset/jni/TestReservationListener.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,9 +122,9 @@ public void unreserve(long size) {
},
errorMessage);
long reservation = reserved.get();
AutoCloseables.close(pool);
long finalReservation = reserved.get();
assertEquals(initReservation, reservation);
assertEquals(initReservation, finalReservation);
// The failed scan can leave work running on Arrow C++ threads that still uses the pool,
// and closing the scanner doesn't wait for it. Closing the pool here would free it under
// that work and crash the JVM, so the pool is left open (GH-1455).
}
}
Loading