Repository navigation
MINOR: Check buffer bounds before writing long decimal values - #1444
Merged
Merged
Conversation
robert3005
requested review from
jbonofre,
laurentgo,
lidavidm and
wgtmac
as code owners
November 8, 2026 00:18
jbonofre
added
enhancement
jbonofre
approved these changes
Nov 11, 2026
jbonofre
left a comment
jbonofre
left a comment
Member
There was a problem hiding this comment.
LGTM, thanks @robert3005!
Good catch on adding the bounds check before writing to the raw memory address.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's Changed
Split out from gh-1228
Avoids out of bounds writes when writing long to decimal buffer, validate the bounds before writing to the address.