Repository navigation
UCLchem interface - #1070
UCLchem interface#1070JStroo2000 wants to merge 44 commits into
Conversation
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 28 days if no further activity occurs. Thank you for your contributions. |
stale
Bot
added
the
status: stale
LourensVeen
added
status: keep-open
rieder
left a comment
rieder
left a comment
There was a problem hiding this comment.
Needs some work:
- remove unintended files/changes
- update to new build system
- download a specific version of UCLChem rather than adding a version to the AMUSE repository
- unittest for the uclchem interface
- preferably: an
amuse.community.interface.chemmodule that the interfaces for UCLChem and Krome inherit from
There was a problem hiding this comment.
Obsolete after recent update to AMUSE installation method
There was a problem hiding this comment.
needs updating to new build system
| .. [#] ADS:2017AJ....154...38H (Holdship, J. ; Viti, S, ; Jiménez-Serra, I.; Makrymallis, A. ; Priestley, F. , 2017, AJ) | ||
| """ | ||
|
|
||
| def __init__(self, mode="cpu", **options): |
There was a problem hiding this comment.
is there another mode than "cpu"?
| return n_out, param_dict, out_species | ||
|
|
||
|
|
||
| class UCLchem(CommonCode): |
There was a problem hiding this comment.
now that there are two chemistry codes, we should try to make amuse.community.interface.chem.ChemistryInterface.
| cm = named("centimeter", "cm", 0.01 * m) | ||
| erg = named("erg", "erg", 1e-7 * J) | ||
| barye = named("barye", "Ba", 0.1 * Pa) | ||
|
|
There was a problem hiding this comment.
reordering should not be done in this PR
|
Closing this since PR #1282 is more up-to-date. |
Adds the chemical evolution code UCLchem as a community code. All the relevant changes are in the community/uclchem folder.