Repository navigation
Require two samples for colored laser noise - #119
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enabling flicker or random-walk laser noise with a single sample passed validation but crashed inside the FFT noise generator. Both validate and run now reject this configuration with a clear message asking for at least two samples. The frequency_noise helper also checks direct calls before invoking the vendored generator. White FM alone still supports one sample.
Updated the configuration reference and theory guide. Regression tests cover both colored components, their combination, the one-to-two-sample boundary including fractional counts, CLI validation and execution, and single-sample white FM. All 137 selected phase-noise, CLI, Nyquist and campaign tests passed locally.