Repository navigation
Scale Rayleigh power in the final partial cell - #118
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A fiber shorter than one spatial cell received the same Rayleigh power as a full cell. The final cell now scales its complex amplitude by the square root of the occupied fraction, so a fiber of length dz/100 has 1% of the full-cell power. Scaling happens before discrete reflectors are added and applies to every core and to segment-specific Rayleigh coefficients.
Updated the theory guide and added regression tests for short fibers, a partially filled final cell, multiple cores, segment overrides and an end-face reflector. All 200 selected fiber, reflector-path, sampling and validation tests passed locally; one HDF5 test needed a rerun outside the sandbox because pytest could not create its temporary directory.