Repository navigation
DO-1765: fail AIO app deploy when a build hook fails - #198
Merged
tmthrgd-aligent merged 1 commit intoNov 10, 2026
Merged
Conversation
aio app deploy logs pre-app-build and post-app-build hook failures but carries on and exits 0 (aio-cli-plugin-app catches them with this.log), unlike the deploy hooks, which stop the deploy. A failing type check or generation hook therefore still deploys and reports success; a non-executable hook deployed no actions at all while the job passed. Keep the deploy output and fail the step if a hook logged "Command failed with exit code N". Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
AdamJHall
approved these changes
Nov 9, 2026
tmthrgd-aligent
deleted the
fix/DO-1765_silent_failure_on_aio_hook_error
branch
November 10, 2026 03:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
aio app deploy logs pre-app-build and post-app-build hook failures but carries on and exits 0 (aio-cli-plugin-app catches them with this.log), unlike the deploy hooks, which stop the deploy. A failing type check or generation hook therefore still deploys and reports success; a non-executable hook deployed no actions at all while the job passed.
Keep the deploy output and fail the step if a hook logged "Command failed with exit code N".
Description of the proposed changes
Screenshots (if applicable)
Other solutions considered (if any)
Notes to PR author
Notes to reviewers
ℹ️ When you've finished leaving feedback, please add a final comment to the PR tagging the author, letting them know that you have finished leaving feedback
Time Tracking
ABC-xxx: code review, select project XXXX