Skip to content

use --system flag to ensure the directory trust is working #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
crispy101 merged 1 commit into from
Nov 12, 2026
+5 −6
Merged

use --system flag to ensure the directory trust is working #59

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
ARG ALPINE_VERSION
RUN : "${ALPINE_VERSION:?ALPINE_VERSION build argument is required}" && touch /validated

FROM php:${PHP_VERSION}-alpine${ALPINE_VERSION} AS standards-runtime

Check warning on line 8 in Dockerfile

View workflow job for this annotation

GitHub Actions / PHP 8.4 / build-and-push

Default value for global ARG results in an empty or invalid base image name 

InvalidDefaultArgInFrom: Default value for ARG php:${PHP_VERSION}-alpine${ALPINE_VERSION} results in empty or invalid base image name
More info: https://docs.docker.com/go/dockerfile/rule/invalid-default-arg-in-from/

Check warning on line 8 in Dockerfile

View workflow job for this annotation

GitHub Actions / PHP 8.4-runtime / build-and-push

Default value for global ARG results in an empty or invalid base image name 

InvalidDefaultArgInFrom: Default value for ARG php:${PHP_VERSION}-alpine${ALPINE_VERSION} results in empty or invalid base image name
More info: https://docs.docker.com/go/dockerfile/rule/invalid-default-arg-in-from/

Check warning on line 8 in Dockerfile

View workflow job for this annotation

GitHub Actions / PHP 8.2-runtime / build-and-push

Default value for global ARG results in an empty or invalid base image name 

InvalidDefaultArgInFrom: Default value for ARG php:${PHP_VERSION}-alpine${ALPINE_VERSION} results in empty or invalid base image name
More info: https://docs.docker.com/go/dockerfile/rule/invalid-default-arg-in-from/

Check warning on line 8 in Dockerfile

View workflow job for this annotation

GitHub Actions / PHP 8.3 / build-and-push

Default value for global ARG results in an empty or invalid base image name 

InvalidDefaultArgInFrom: Default value for ARG php:${PHP_VERSION}-alpine${ALPINE_VERSION} results in empty or invalid base image name
More info: https://docs.docker.com/go/dockerfile/rule/invalid-default-arg-in-from/

Check warning on line 8 in Dockerfile

View workflow job for this annotation

GitHub Actions / PHP 8.2 / build-and-push

Default value for global ARG results in an empty or invalid base image name 

InvalidDefaultArgInFrom: Default value for ARG php:${PHP_VERSION}-alpine${ALPINE_VERSION} results in empty or invalid base image name
More info: https://docs.docker.com/go/dockerfile/rule/invalid-default-arg-in-from/

Check warning on line 8 in Dockerfile

View workflow job for this annotation

GitHub Actions / PHP 8.3-runtime / build-and-push

Default value for global ARG results in an empty or invalid base image name 

InvalidDefaultArgInFrom: Default value for ARG php:${PHP_VERSION}-alpine${ALPINE_VERSION} results in empty or invalid base image name
More info: https://docs.docker.com/go/dockerfile/rule/invalid-default-arg-in-from/
COPY --from=validator /validated /tmp/.validated

# Install system dependencies
Expand Down Expand Up @@ -66,11 +66,10 @@
/venv/bin/pip install --upgrade pip && \
/venv/bin/pip install --no-cache-dir -r /requirements.txt

# Allow git access to mounted build directories
RUN git config --global --add safe.directory /build
RUN mkdir -p /opt/atlassian/pipelines/agent/build
RUN git config --global --add safe.directory /opt/atlassian/pipelines/agent/build
RUN mkdir -p /github/workspace
RUN git config --global --add safe.directory /github/workspace
# Allow git access to mounted build directories.
RUN mkdir -p /opt/atlassian/pipelines/agent/build /github/workspace && \
git config --system --add safe.directory /build && \
git config --system --add safe.directory /opt/atlassian/pipelines/agent/build && \
git config --system --add safe.directory /github/workspace

ENTRYPOINT ["/pipe.py"]
Loading