Skip to content

e2e: export koApply, use it in egressauthz - #1925

Open
Eric Curtin (ericcurtin) wants to merge 1 commit into
agent-substrate:mainfrom
ericcurtin:export-koapply
Open

Eric Curtin (ericcurtin) wants to merge 1 commit into
agent-substrate:mainfrom
ericcurtin:export-koapply

Conversation

@ericcurtin

@ericcurtin Eric Curtin (ericcurtin) commented Sep 27, 2026 •

Copy link
Copy Markdown
Contributor

Fixes #1251.

Export koApply and use it in egressauthz instead of a copy.

  • Tests pass
  • Appropriate changes to documentation are included in the PR

@ericcurtin

Copy link
Copy Markdown
Contributor Author

Tim Bai (@baizhenyu) Benjamin Elder (@BenTheElder) PTAL when you get a chance. Thank you!

@bowei Bowei Du (bowei) added area/tests Enhancing / fixing test coverage. kind/cleanup Small fixes that are not bugs, for example a typo in a code comment labels Sep 30, 2026
@ericcurtin

Copy link
Copy Markdown
Contributor Author

Lior Lieberman (@LiorLieberman) Taahir Ahmed (@ahmedtd) PTAL when you get a chance. Thank you!

@ericcurtin

Copy link
Copy Markdown
Contributor Author

Eitan Yarmush (@EItanya) Max Smythe (@maxsmythe) PTAL when you get a chance. Thank you!

@ericcurtin

Copy link
Copy Markdown
Contributor Author

Zoe Zhao (@zoez7) Dmitry Berkovich (@dberkov) PTAL when you get a chance. Thank you!

@ericcurtin

Copy link
Copy Markdown
Contributor Author

Benjamin Elder (@BenTheElder) Tim Hockin (@thockin) It has one approval and no conflicts. PTAL when you get a chance. Thank you!

egressauthz_test.go duplicated the ko apply logic that koApply
already had. Export it and call it instead.

Signed-off-by: Eric Curtin <eric.curtin@docker.com>
auto-merge was automatically disabled November 16, 2026 11:20

Head branch was pushed to by a user without write access

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/tests Enhancing / fixing test coverage. kind/cleanup Small fixes that are not bugs, for example a typo in a code comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Suggestion: Refactor koApply to an Exported Helper

3 participants