Repository navigation
e2e: export koApply, use it in egressauthz - #1925
Open
Eric Curtin (ericcurtin) wants to merge 1 commit into
Open
Eric Curtin (ericcurtin) wants to merge 1 commit into
Eric Curtin (ericcurtin) wants to merge 1 commit into
Conversation
Contributor
Author
|
Tim Bai (@baizhenyu) Benjamin Elder (@BenTheElder) PTAL when you get a chance. Thank you! |
Contributor
Author
|
Lior Lieberman (@LiorLieberman) Taahir Ahmed (@ahmedtd) PTAL when you get a chance. Thank you! |
Contributor
Author
|
Eitan Yarmush (@EItanya) Max Smythe (@maxsmythe) PTAL when you get a chance. Thank you! |
Contributor
Author
|
Zoe Zhao (@zoez7) Dmitry Berkovich (@dberkov) PTAL when you get a chance. Thank you! |
Dmitry Berkovich (dberkov)
approved these changes
Oct 24, 2026
Dmitry Berkovich (dberkov)
enabled auto-merge
October 24, 2026 02:49
Contributor
Author
|
Benjamin Elder (@BenTheElder) Tim Hockin (@thockin) It has one approval and no conflicts. PTAL when you get a chance. Thank you! |
2 tasks done
1 of 2 tasks
egressauthz_test.go duplicated the ko apply logic that koApply already had. Export it and call it instead. Signed-off-by: Eric Curtin <eric.curtin@docker.com>
auto-merge was automatically disabled
November 16, 2026 11:20
Head branch was pushed to by a user without write access
Eric Curtin (ericcurtin)
force-pushed
the
export-koapply
branch
from
November 16, 2026 11:20
2258f9e to
e265222
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1251.
Export koApply and use it in egressauthz instead of a copy.