Repository navigation
fix: require a hostname in url() - #259
Closed
dajiaohuang wants to merge 1 commit into
Closed
dajiaohuang wants to merge 1 commit into
dajiaohuang wants to merge 1 commit into
Conversation
Owner
|
Thanks for the PR! I don't really see this as a problem though– if it's a valid url, it's a valid url. If you want to create a stricter validation to ensure there's a hostname, a custom validator is probably the right place for that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
The README describes
url()as requiring a protocol and hostname, butnew URL()also accepts valid non-host URL forms such asmailto:. The validator now rejects parsed URLs without a hostname while continuing to accept host-bearing custom schemes. Error messages remain generic and do not include the input value.Tests and validation
mailto:case; it failed before the change because validation accepted it.bun run test:ci -- tests/validators.test.ts— 9 passedbun run ts— passedbun run lint— passedgit diff --check— passedNo real
process.env,.env, credentials, user profile, deployment configuration, or service was accessed. No full suite/build was run.