[shashank-tomar0]

Summary

Fixes #77.

Extracting qt6-webengine_6.8.2+dfsg-4.debian.tar.xz put
LICENSES/Qt-GPL-exception-1.0.txt in the extraction root under the garbled
name qt6-webengine-6.8.2Min _nyopeQu _ GPL-exception-1.0.txt.

Root cause

Entry.get_path() decodes libarchive byte pathnames with
commoncode.text.as_unicode(), which uses BeautifulSoup's UnicodeDammit.
For the plain ASCII bytes of
qt6-webengine-6.8.2+dfsg/LICENSES/Qt-GPL-exception-1.0.txt, UnicodeDammit
picks UTF-7 and turns +dfsg/LICENSES/Qt- into CJK characters:

>>> from bs4 import UnicodeDammit
>>> p = b"qt6-webengine-6.8.2+dfsg/LICENSES/Qt-GPL-exception-1.0.txt"
>>> UnicodeDammit(p).original_encoding
'utf-7'
>>> UnicodeDammit(p).unicode_markup
'qt6-webengine-6.8.2\u75fb\u20fc\ub202\u10d4\u844b\uf42dGPL-exception-1.0.txt'

The separators are lost, so the file lands in the wrong directory.

Changes

• Added as_unicode_path() in src/extractcode/libarchive2.py.
• Archive paths are now decoded deterministically as UTF-8 first, since that is
  what modern archives use and plain ASCII is valid UTF-8.
• Paths that are not valid UTF-8 still go through the previous charset
  detection, so existing non-UTF-8 archives keep their current behavior.
• None and empty paths are handled as before.

Tests

$ python -m pytest tests/test_libarchive2.py -q
5 passed

New tests:

• test_as_unicode_path_does_not_decode_plain_ascii_as_utf7
• test_as_unicode_path_decodes_utf8
• test_as_unicode_path_handles_missing_paths
• test_extract_tar_keeps_directories_with_a_plus_sign

The last test builds a tar with the exact path from the report and extracts
it through libarchive. With the previous decoder it produced
qt6-webengine-6.8.2Min _nyopeQu _ GPL-exception-1.0.txt in the target root;
with this change it produces the expected
qt6-webengine-6.8.2+dfsg/LICENSES/Qt-GPL-exception-1.0.txt.

The tests/test_archive.py suite was also run. Its four failures are
pre-existing 7-Zip environment failures (system 7z instead of the
extractcode-7z plugin) and reproduce identically on pristine main.

ruff format --check and ruff check pass for the changed files.

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.