Skip to content

feat: add display settings menu to V3 markets filter bar - #3177

Open
sammdec wants to merge 3 commits into
mainfrom
samm/v3-display-settings-menu
Open

sammdec wants to merge 3 commits into
mainfrom
samm/v3-display-settings-menu

Conversation

@sammdec

@sammdec sammdec commented Nov 10, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Adds a Display settings menu to the V3 markets filter bar, modelled on Aave Pro's display dropdown. The restricted-assets and low-supply toggles move from the bottom of the markets table into this menu.

  • DisplaySettingsMenu (new, src/components/DisplaySettingsMenu.tsx): a sliders button that opens a popover. It takes switch rows (label, optional info tooltip, checked/onChange) grouped into sections with dividers between them, plus a Reset action that is disabled while every setting is at its default.
  • Built on V3's existing MUI theme: colour tokens, the Pro-styled Switch, the ScaleFade popover transition and TextWithTooltip. It doesn't port Pro's Radix-based Dropdown, so there are no new dependencies. Panel geometry copies Pro's: 12px radius, 266px wide, uppercase 11px heading.
  • ManageIcon (new): Pro's sliders glyph.
  • AssetsFilterBar: new optional displaySettings slot, grouped with the category filter so the two stay together on phones. The staking and umbrella pages don't pass it and are unchanged.
  • Markets: "Show <$1M supply" / "Show <$100k supply" and "Show restricted assets" now live in the menu. The restricted row only shows when the market has restricted assets, as before. Reset turns both off.
  • i18n catalogs regenerated. New strings: "Display", "Reset", "Display settings", and a tooltip for the supply-threshold row ("Assets with less than $1M / $100k supplied are hidden by default.").

Test plan

  • V3 Core Ethereum: menu opens beside All Categories; Reset is disabled by default
  • Toggling restricted assets shows the restricted list and its alert; toggling the supply threshold shows the smaller assets
  • Reset turns both off and the list returns to the default
  • Clicking an info icon opens its tooltip without flipping the switch
  • 390px viewport: button sits next to Categories and the panel fits on screen
  • Another market (e.g. Arbitrum): row reads "Show <$100k supply"
  • Light mode visual check

🤖 Generated with Claude Code

Move the restricted-assets and low-supply toggles from the bottom of the
markets table into a Display popover beside the category filter, modelled
on Aave Pro's display dropdown and built on the existing MUI theme.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@vercel

vercel Bot commented Nov 10, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
interface Ready Ready Preview Nov 10, 2026 3:35pm UTC

Request Review

@github-actions

Copy link
Copy Markdown

@github-actions

Copy link
Copy Markdown

📦 Next.js Bundle Analysis for aave-ui

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

Restricted assets move out of the display settings menu into a collapsed
section below the markets table. A deprecated section is wired up but stays
hidden until deprecation logic exists.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown

@github-actions

Copy link
Copy Markdown

📦 Next.js Bundle Analysis for aave-ui

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@sammdec
sammdec marked this pull request as ready for review November 10, 2026 15:35
@github-actions

Copy link
Copy Markdown

@github-actions

Copy link
Copy Markdown

📦 Next.js Bundle Analysis for aave-ui

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

This branch was successfully deployed

1 active deployment
Preview — 6fc590b2 Deployed Nov 10, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants