Repository navigation
Tests for the VFP menu functions - #2162
Merged
Merged
Conversation
Tests for BAR, PAD, POPUP, MENU, MRKBAR, MRKPAD, PRMBAR and PRMPAD using menus built with the DEFINE commands, checked against VFP 9. They found a few problems that are fixed here too: the plain DEFINE and ACTIVATE POPUP forms weren't expanded by the header, RELEASE MENUS/POPUPS with a list didn't compile, PRMBAR/MRKBAR/BAR used the bar position instead of its number, prompts kept the \< marker, names were case sensitive, RELEASE MENUS left the menu registered and PAD()/MENU() were empty when the bar was selected without opening the menu.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added tests for the menu functions (BAR, PAD, POPUP, MENU, MRKBAR, MRKPAD, PRMBAR, PRMPAD) using menus built with the DEFINE commands, and compared the results with VFP 9.
While writing them I found a few problems, so they're fixed here as well:
Unknown names still return an empty string or .F. instead of raising an error like VFP does. That's how the existing tests expect it, so I left it that way.