Repository navigation
[VS] Find References: fix SelectTarget after the merge of #2154 and #2156 - #2161
Merged
RobertvanderHulst merged 1 commit intoNov 8, 2026
Merged
Conversation
…and X-Sharp#2156 The squash merge of X-Sharp#2156 mixed the SelectTarget method from X-Sharp#2154 (Rename) with the old inline lookup, so FindReferencesCommand.cs did not compile. SelectTarget now resolves the symbol through TargetUnderCursor.Resolve and fills TargetSelection from it; messages are unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FindReferencesCommand.csdoes not compile ondevsince #2156 was merged (reported by Robert in #2156).Cause: the squash merge of #2156 collided with
SelectTarget, which #2154 (Rename) added to the same file. The conflict resolution mixed both versions: anawaitin a non-async method, duplicatetarget/locationvariables, an undefineddocand an orphanedcatchblock.Fix:
SelectTargetkeeps the shape from #2154 but resolves the symbol throughTargetUnderCursor.Resolve(the shared helper from #2156) and fillsTargetSelectionfrom it. Messages are unchanged; Rename, Find References and Go To Implementation use the same lookup again.Verified:
LanguageService2022.csproj(Debug, AnyCPU) builds without errors. Not re-tested manually in VS.🤖 Generated with Claude Code