Repository navigation
build(audit): skip picomatch GHSA-fc5q-39xc-vjpf in the dependency audits until a fix ships - #678
Merged
Merged
Conversation
…dits until a fix ships No fixed picomatch exists (<= 4.0.7 is affected), and every deploy since 17:40 UTC failed both dependency audits on it. picomatch reaches the site only through fumadocs-core and fumadocs-mdx (tinyglobby, fdir), which glob content files at build time with the site's own patterns; the static export sends visitors none of it (0 hits in the live site's 39 JS chunks). - pnpm-workspace.yaml: audit.ignore lists the advisory. - .github/workflows/audit.yml: the two audits of cli-base's release-checks.yml, the npm one filtered with jq to skip only this advisory and fail on any other high or critical one. The shared check has no ignore input, so deploy, monthly and security-release pass dependencies: false and call audit.yml instead. - security-release.yml: security-events: write moves onto the shared job. - DOCS-14 removes all of it once picomatch is fixed or release-checks.yml takes an ignore input. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
leemour
added a commit
to WireCatLabs/cli-base
that referenced
this pull request
Nov 17, 2026
…dependency audits (#628) Adds **BASE-11** (P2) to the backlog. Backlog only, no code. `release-checks.yml` should take a list of advisories to skip in both dependency audits (`pnpm audit --prod` at line 53 and the npm audit of the packed package at line 73). npm has no per-advisory ignore, so a repository that must skip one advisory has to copy both audits. cli-docs did this for picomatch GHSA-fc5q-39xc-vjpf, which has no fixed version and runs only at build time there (WireCatLabs/cli-docs#678, its DOCS-14). With the input, cli-docs can drop its copy. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task
Unblock deploys. Every Deploy run since 17:40 UTC (44139609605, 44143423852, 44148152583) failed in
security / dependenciesandsecurity / resolved-dependencieson picomatch GHSA-fc5q-39xc-vjpf (ReDoS through attacker-written extglob patterns). No fixed version exists: every picomatch up to 4.0.7, the latest, is affected. #675, #676, #668 and #677 are merged but not live.Why it is safe to skip
pnpm why picomatch --prod):picomatch@4.0.7←fdir@6.5.0←tinyglobby@0.2.17←fumadocs-core@16.17.8/fumadocs-mdx@15.4.10← cli-docs. fumadocs uses it to find content files at build time, with the site's own patterns.output: "export"), and visitors do not download picomatch. The 16:50 deploy (7b75117) has the same lockfile, package.json, pnpm-workspace.yaml and next.config.mjs as main. In its 39 JS chunks (12 pages, with runtime chunk references followed), picomatch's error strings,POSIX_REGEX_SOURCE,picomatch,tinyglobbyandfdiroccur 0 times. The same strings are found in the picomatch package itself, and fumadocs' own client code is in 4 of those chunks.What
pnpm-workspace.yaml:audit.ignorelists only this advisory, with why and "remove when picomatch ships a fix"..github/workflows/audit.yml(new): the two dependency audits of cli-base'srelease-checks.yml. The npm audit of the packed site is filtered with jq to skip only this advisory, and fails on any other high or critical one or on a missing report. npm has no per-advisory ignore, and the shared workflow has no ignore input in any version up to main.deploy.yml,monthly.yml,security-release.yml: the shared check runs withdependencies: false, andaudit.ymlruns beside it (in deploy,buildwaits for it). Insecurity-release.yml,security-events: writemoves from the workflow onto the shared job, so the new job stays read-only.docs/dev/BACKLOG_LATER.md: DOCS-14 removes all of this once picomatch is fixed orrelease-checks.ymltakes an ignore input.Testing
pnpm audit --prod --audit-level high: exit 0 ("1 ignored: 1 high", 2 moderate below the gate)..github/workflows.pnpm lint,standards:check, markdownlint, vitest (49 files, 525 tests).🤖 Generated with Claude Code