Skip to content

test(sidebar): count a service logo image as the link's decorative icon - #674

Merged
leemour merged 1 commit into
mainfrom
fix/sidebar-logo-icon-test
Nov 17, 2026
Merged

leemour merged 1 commit into
mainfrom
fix/sidebar-logo-icon-test

Conversation

@leemour

@leemour leemour commented Nov 17, 2026

Copy link
Copy Markdown
Member

The deploy after #672 was skipped: browser shard 2 failed 12 times in tests/file-attachments.spec.ts (run). The missing icons were /docs/google-meet, /docs/telemost and (RU) /docs/beeline. #673 gave them their own logos as <img alt=""> (ServiceLogo in components/brand-icons.tsx), and the test only looked for svg[aria-hidden="true"].

The logo is decorative in the same way, so the test now accepts svg[aria-hidden="true"], img[alt=""]. No site change. Full validation is dispatched on this branch, which runs this spec.

🤖 Generated with Claude Code

#673 gave Google Meet, Telemost and Beeline their own logos in the docs
sidebar, rendered as <img alt=""> (ServiceLogo). The attachments test still
looked only for svg[aria-hidden], so it reported those three links as
having no icon, failed browser shard 2 of the deploy for #672, and the
deploy was skipped. The logos are decorative in the same way, so the test
now accepts either.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@leemour

leemour commented Nov 17, 2026

Copy link
Copy Markdown
Member Author

Full validation on this branch: the check job's next build was stopped twice by the runner ("The runner has received a shutdown signal", attempts 1 and 2 of run 44126652605), at 1 min 43 s and 3 min 18 s, with no build error in the log. The search-playground job built the same commit in 5 min. The change is one test selector, so it cannot affect the build. Merging and letting the deploy's build and four browser shards check it.

@leemour
leemour merged commit 7b75117 into main Nov 17, 2026
12 of 14 checks passed
@leemour
leemour deleted the fix/sidebar-logo-icon-test branch November 17, 2026 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant