Repository navigation
test(sidebar): count a service logo image as the link's decorative icon - #674
Merged
Merged
Conversation
#673 gave Google Meet, Telemost and Beeline their own logos in the docs sidebar, rendered as <img alt=""> (ServiceLogo). The attachments test still looked only for svg[aria-hidden], so it reported those three links as having no icon, failed browser shard 2 of the deploy for #672, and the deploy was skipped. The logos are decorative in the same way, so the test now accepts either. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
Author
|
Full validation on this branch: the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The deploy after #672 was skipped: browser shard 2 failed 12 times in
tests/file-attachments.spec.ts(run). The missing icons were/docs/google-meet,/docs/telemostand (RU)/docs/beeline. #673 gave them their own logos as<img alt="">(ServiceLogoincomponents/brand-icons.tsx), and the test only looked forsvg[aria-hidden="true"].The logo is decorative in the same way, so the test now accepts
svg[aria-hidden="true"], img[alt=""]. No site change. Full validation is dispatched on this branch, which runs this spec.🤖 Generated with Claude Code