Repository navigation
Conversation
Rebuild with Emscripten 6.0.13 (was 3.1.73). SQLite stays at 3.48.0 and benchmark.js is unchanged, so the benchmark runs the same SQL as before. - Emscripten 4.0 made the MODULARIZE factory async, which runs SQLite 3.48's --post-js init too late: EmscriptenModule.sqlite3 stays undefined, and the shells fail with "Cannot set properties of undefined (setting 'scriptInfo')". emscripten-4-post-load-init.patch backports Module.runSQLite3PostLoadInit from SQLite 3.49.0. It changes only the JS glue. Drop it when updating to SQLite 3.49.0 or later. - Pass INCOMING_MODULE_JS_API through EMCC_CFLAGS, since Emscripten 6.0.2 removed wasmBinary from the default list. speedtest1.wasm now uses bulk memory (271 memory.copy, 217 memory.fill). Score change, d8 (15.9.60) / jsc (325217) / SpiderMonkey (160.0b3) (each test alone in a fresh shell, 6 rounds): +15.2% / -0.2% / +11.7%. Part of WebKit#277.
✅ Deploy Preview for webkit-jetstream-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
danleh
commented
Nov 3, 2026
Contributor
Author
There was a problem hiding this comment.
Will be removed again in the followup https://github.com/WebKit/JetStream/pull/328/changes where the benchmark source is updated, so this backport is no longer necessary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #277.
Rebuild
sqlite3-wasmwith Emscripten 6.0.13 (was 3.1.73). SQLite stays at 3.48.0 andbenchmark.jsdoes not change, so the benchmark runs the same SQL as in 3.0.To review (2 files, +48/−1; the other 3 files are build output):
emscripten-4-post-load-init.patch(new, 41 lines) backportsModule.runSQLite3PostLoadInitfrom SQLite 3.49.0. Emscripten 4.0 made theMODULARIZEfactory async, which runs SQLite 3.48's--post-jsinit too late:EmscriptenModule.sqlite3stays undefined, and the shells fail with "Cannot set properties of undefined (setting 'scriptInfo')". The patch changes only the JS glue.build.shapplies the patch and passesINCOMING_MODULE_JS_APIthroughEMCC_CFLAGS, as in Rebuild Emscripten C/C++ workloads with emcc 6.0.13 #324.Binaries:
speedtest1.wasmnow uses bulk memory (271memory.copy, 217memory.fill) and is 14 KB smaller.Scores (measured on a Linux x64 workstation with
jsvushells, each test alone in a fresh shell, 6 rounds; change of the mean score, rounds won in parentheses, bold = statistically significant at 95% confidence; @kmiller68 may want to check on macOS / arm64):d8(15.9.60)jsc(325217)sqlite3-wasmFirst and Average subscores
d8First / AveragejscFirst / Averagesqlite3-wasmReproduce:
cd workloads/sqlite3-wasm && ./build.shwith emsdk 6.0.13 active. A rebuild reproducesspeedtest1.jsandspeedtest1.wasmbit for bit.Updating SQLite itself to 3.54.1 is stacked in #328 so the compiler rebuild and the library update can be reviewed separately.