Skip to content

Add ldap and status not specified fault categories - #53

Merged
arcuri82 merged 3 commits into
masterfrom
add-ldap-and-status-not-specified-fault-categories
Oct 28, 2026
Merged

arcuri82 merged 3 commits into
masterfrom
add-ldap-and-status-not-specified-fault-categories

Conversation

@ThomasTNO

Copy link
Copy Markdown
Collaborator

Adds two new fault categories identified while implementing WFC report support in WuppieFuzz: TNO-S3/WuppieFuzz#397

  • HTTP_STATUS_NOT_SPECIFIED (126) – undeclared status code outside the 5xx range (1xx–4xx), mirroring existing 5xx coverage (HTTP_STATUS_500, HTTP_OTHER_STATUS_5XX).
  • SECURITY_LDAP_INJECTION (317) – completes the injection category set alongside SQL/XSS/NoSQL/Command injection.

Also synced the json.

@ThomasTNO
ThomasTNO requested a review from arcuri82 October 28, 2026 09:31
@arcuri82

Copy link
Copy Markdown
Contributor

hi @ThomasTNO. the HTTP_STATUS_NOT_SPECIFIED is technically already handled in SCHEMA_INVALID_RESPONSE. however, maybe it could make sense to have separated categories for wrong status (ie not specified in schema) and wrong bodies (ie not matching structure specified in schema). or maybe just extend the description of SCHEMA_INVALID_RESPONSE with more details and examples.
@ThomasTNO @grebnetiew @Stranger6667 @en-milie what do you think?

@ThomasTNO

Copy link
Copy Markdown
Collaborator Author

A distinction between the two (status/response code vs response body) would be valuable if you ask me

@arcuri82

Copy link
Copy Markdown
Contributor

we could remove SCHEMA_INVALID_RESPONSE and introduce two new separated categories: SCHEMA_INVALID_RESPONSE_BODY and SCHEMA_INVALID_RESPONSE_STATUS. how does it sound?

@ThomasTNO

Copy link
Copy Markdown
Collaborator Author

we could remove SCHEMA_INVALID_RESPONSE and introduce two new separated categories: SCHEMA_INVALID_RESPONSE_BODY and SCHEMA_INVALID_RESPONSE_STATUS. how does it sound?

I would like that

@arcuri82

Copy link
Copy Markdown
Contributor

@ThomasTNO you can remove HTTP_STATUS_NOT_SPECIFIED from this PR. then, if @Stranger6667 and @en-milie agree on replacing SCHEMA_INVALID_RESPONSE, I can do it on a separated PR

@ThomasTNO
ThomasTNO force-pushed the add-ldap-and-status-not-specified-fault-categories branch from d19a5c1 to 7d32570 Compare October 28, 2026 10:59
"id" : "SECURITY_MISSING_HEADERS",
"label" : "F316:Missing Security Headers",
"testCaseLabel" : "missingSecurityHeaders"
}, {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx. i will need to write some documentation to explain all steps needed when adding a new code. for example, constraints under src/main/resources/wfc/schemas/report.yaml needs to be updated for FaultCategoryId, as well as need to update release_notes.md

@ThomasTNO

Copy link
Copy Markdown
Collaborator Author

@arcuri82 please tag me as soon as the other PR is present. I can then directly incorporate it in our WIP PR on enabling WFC report in WuppieFuzz. Ideally I would prefer a new release as well so that versioning of the standard stays aligned.

@arcuri82
arcuri82 merged commit 1531225 into master Oct 28, 2026
4 checks passed
@arcuri82
arcuri82 deleted the add-ldap-and-status-not-specified-fault-categories branch October 28, 2026 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants