Repository navigation
Make the checkbox widget accessible to keyboard and screen-reader users - #92
Merged
Merged
Conversation
…en-reader users Give the checkbox an accessible name, announce verifying/verified/failure through a polite status region, mark it busy while verifying, add a visible focus ring, and keep a failure message on screen until the next attempt instead of clearing it after three seconds.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "I'm not a robot" checkbox widget is the interactive step an application can show when clearance needs a person. It could be operated from the keyboard, but a screen reader got little from it:
Changes:
aria-labelon the checkbox; the duplicate visible text is hidden from the accessibility tree.role="status"region announces verifying, verified and failure (with how to retry).aria-busy/aria-disabledwhile verifying.:focus-visiblering.src/widget.test.tscovers the name, Space/Enter activation, announcements, the persistent failure message and reset. All six tests fail against the previous widget.